feat: add shared drain pipeline for batching and retry #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you for following the naming conventions! 🙏 |
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new shared drain “pipeline” to evlog to support buffered batching with retry semantics, and updates several drains and the playground to exercise batch delivery.
Changes:
- Add
createDrainPipeline(buffering + batch flush on size/interval + retry/backoff + overflow dropping) and export it asevlog/pipeline. - Update Axiom/PostHog/Sentry drains to accept batched contexts and send via new batch senders.
- Add Vitest coverage for batching/retry/overflow/flush behaviors and add a playground UI section to trigger pipeline batching.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/evlog/tsdown.config.ts | Adds pipeline build entry so it’s emitted to dist. |
| packages/evlog/src/pipeline.ts | Introduces the batching/retry pipeline implementation and its public API. |
| packages/evlog/test/pipeline.test.ts | Adds tests for batching, interval flush, retry strategies, buffer overflow, and flush/pending. |
| packages/evlog/src/adapters/axiom.ts | Updates drain to accept batch inputs and uses batch sender. |
| packages/evlog/src/adapters/posthog.ts | Updates drain to accept batch inputs and uses batch sender. |
| packages/evlog/src/adapters/sentry.ts | Updates drain to accept batch inputs and uses batch sender. |
| packages/evlog/package.json | Exposes ./pipeline via exports/typesVersions. |
| apps/playground/app/pages/index.vue | Adds a UI action to fire 10 requests in parallel for batching. |
| apps/playground/app/config/tests.config.ts | Adds a “Pipeline” test section to the playground UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new batching and retry pipeline for event drains in the
evlogpackage, enabling efficient, configurable buffering and delivery of events to external services. It updates the Axiom, PostHog, and Sentry adapters to support batch delivery, adds comprehensive tests for the new pipeline, and integrates the pipeline into the playground app for interactive testing.