Skip to content

Support PI User Authentication mode with empty password #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jinzy wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Support PI User Authentication mode with empty password #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions PIconnect/PI.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ def __init__(
if server and server not in self.servers:
message = 'Server "{server}" not found, using the default server.'
warn(message=message.format(server=server), category=UserWarning)
if bool(username) != bool(password):
Copy link
Owner

@Hugovdberg Hugovdberg Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that a username without a password is a valid case, but a password without a user is still invalid, right? In that case we should not remove this check entirely, but make it more similar to the next check for a domain without a username.

raise ValueError(
"When passing credentials both the username and password must be specified."
)
if domain and not username:
raise ValueError(
"A domain can only specified together with a username and password."
Expand All @@ -92,8 +88,10 @@ def __init__(
from System.Security import SecureString

secure_pass = SecureString()
for c in password:
secure_pass.AppendChar(c)

if password != None:
for c in password:
secure_pass.AppendChar(c)
cred = [username, secure_pass] + ([domain] if domain else [])
self._credentials = (NetworkCredential(*cred), int(authentication_mode))
else:
Expand Down