Major reorganisation in prep for 1.0 #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notebooks in the root folder should only be used for debugging locally. Inclusion in the documentation could be valid.
Primarily added the Search module
Renamed Time module for parallel with module in the SDK. Import the SDK as SDK to prevent name clash with new AF module to mirror the AF module in the SDK.
PIData -> Data PIPoint +>PI PIAFAttribute +> Asset
- move AF modules in AF package - rename dotnet to System
As automatic detection of the libraries often failed and made testing very difficult the code was reorganised to require an explicit import of the .NET libraries. This way importing the PIconnect library can always succeed, regardless of the environment. The major downside is that it requires an explicit `PI.load_sdk()` call in every script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing the .NET libraries now requires an explicit
PIconnect.load_sdk()in order to simplify testing and make sure the python package can always be imported.Furthermore, the code was reorganised in order to more closely reflect the SDK structure.