Skip to content

fix: allow empty string as password #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hugovdberg wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: allow empty string as password #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ca3fb4
fix: allow empty string as password
Hugovdberg Aug 14, 2025
70c0e59
Update password documentation in PI.py
Hugovdberg Sep 19, 2025
3b71360
mnt: update lockfile
Hugovdberg Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions PIconnect/PI.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,8 @@ class PIServer:
username : str, optional
Username to connect to the server, defaults to None
password : str, optional
Password for the username, defaults to None
Password for the username, defaults to None. When a username is specified a
password must be passed in as well, but it can be empty.
domain : str, optional
Domain of the username, defaults to None
authentication_mode : AuthenticationMode, optional
Expand Down Expand Up @@ -295,7 +296,7 @@ def __init__(
)
self.connection = default_server

if bool(username) != bool(password):
if (username is not None) != (password is not None):
raise ValueError(
"When passing credentials both the username and password must be specified."
)
Expand Down
Loading
Loading