Open
Conversation
AdityasCode
requested review from
OwenMetzger646,
ParkerHiggins,
Copilot,
jmehling,
michaelangell and
rkcetin
There was a problem hiding this comment.
Copilot reviewed 104 out of 112 changed files in this pull request and generated 3 comments.
Files not reviewed (8)
- .idea/HypeTrade.iml: Language not supported
- .idea/inspectionProfiles/Project_Default.xml: Language not supported
- .idea/misc.xml: Language not supported
- HypeTrade307/.gitignore: Language not supported
- HypeTrade307/components.json: Language not supported
- HypeTrade307/package.json: Language not supported
- HypeTrade307/public/data.json: Language not supported
- HypeTrade307/public/data2.json: Language not supported
| </div> | ||
| <ResponsiveContainer width="102%" height={300}> | ||
| <LineChart data={data} margin={{ top: 10, right: 30, left: 0, bottom: 0 }}> | ||
| <XAxis dataKey="name" /> |
There was a problem hiding this comment.
The XAxis is using 'name' as the dataKey, but the fetched data points use the 'date' field. Change 'name' to 'date' to ensure proper display.
Suggested change
| <XAxis dataKey="name" /> | |
| <XAxis dataKey="date" /> |
|
|
||
| const fetchData = async (): Promise<DataPoint[]> => { | ||
| try { | ||
| const response = await fetch("/data/.json"); |
There was a problem hiding this comment.
The fetch URL appears to be a typo ("/data/.json"). It should likely be "/data.json".
Suggested change
| const response = await fetch("/data/.json"); | |
| const response = await fetch("/data.json"); |
AdityasCode
assigned
AdityasCode,
ParkerHiggins,
rkcetin,
OwenMetzger646,
jmehling and
michaelangell
… to the portfolio page and clicking on the stock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so many conflicts