Add Support OpenStack API V1 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoftLayer Object Storage still uses the OpenStack API V1, so we need to indicate in the call to pkgcloud. API Version now passed as a parameter and API specific client info generated as a result Credential key type for V2 fixed Reverting back to custom pkgcloud dependency
Contributor
|
@ahadik please see my comments in IBM-Cloud/node-file-upload-swift#16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bluemix uses Swift API V2 for and SoftLayer uses V1. Luckily,
pkgcloud, the dependency that's doing the heavy lifting for authentication has support for V1 and V2. However, some modification need to be made to Skipper-Openstack so that an app can indicate that a set of credentials are formatted for V1 or V2. This PR adds that functionality by expecting an integer as an argument along with credentials.To demonstrate the functionality of this new capability, I have forked and created two copies of the
node-file-upload-swiftapp, one that uses my new version of Skipper-Openstack to authenticate with Bluemix Object Storage node-file-upload-swift and one that that uses this new version of Skipper-Openstack to authenticate with SoftLayer Object Storage node-file-upload-swift-softlayer.I will shortly be submitting the Bluemix version of this app as a PR to the original node app from a branch of the SoftLayer app fork.