-
Notifications
You must be signed in to change notification settings - Fork 122
Project - Gaia Leuzzi #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mucss-dataviz ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
leuzzi-gaia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the real final version of my graphs, both reproduction and improvement versions, at least until feedbacks will come!
leuzzi-gaia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it with the feedback from Monday presentation's session.
Enchufa2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left several comments. Note that you have a second Rmd (Improved_version.Rmd), which needs to be removed. If this one contains something useful, it should be moved into the main one.
Please ensure that you follow the project guidelines: https://csslab.uc3m.es/dataviz/tutorials/project/#project-guidelines. And let me know when you have 100% completion by marking the pull request as "ready for review".
| ``` | ||
|
|
||
| ## Visual geometry construction | ||
| ```{r plot, fig.width=70, fig.height=65, fig.showtext=TRUE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but this is waaaay too big. I know that changing this creates problems in the sizing of the text, which need to be adjusted, sorry, but I cannot merge projects with many MB of images. Note that 70 is 70 inches (!!!). 7 inches is a good width. Scale everything down, please.
| x = 0.3, y = 0.92, | ||
| hjust = 0, vjust = 1, | ||
| fontfamily = "nunito_title", | ||
| size = 140, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean... 140 is huge. Divide everything by 10.
Here you will find the two photos of the icons, the dataset, the reproduction and the improvement rmd files + their respective html.