-
Notifications
You must be signed in to change notification settings - Fork 122
Project - Clare McGarvey #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mucss-dataviz ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Enchufa2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left several comments. There are some files missing. Note that after every change and recompilation, you need to select everything under _projects for the commit&push.
Please ensure that you follow the project guidelines: https://csslab.uc3m.es/dataviz/tutorials/project/#project-guidelines. And let me know when you have 100% completion by marking the pull request as "ready for review" again.
| toc: true | ||
| --- | ||
|
|
||
| # Graph Project - Abortion Access in the USA, Febuary 2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove.
|
|
||
| # Graph Project - Abortion Access in the USA, Febuary 2023 | ||
|
|
||
| ## FiveThirtyEight Replication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduction?
|
|
||
| ```{r} | ||
| # Fuel | ||
| fuel <- read_xls(path = "data/gasprices_region.xls", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dataset is huge (~7 MB). Is everything here necessary? Is it possible to save just the dataframe you need in a smaller CSV file?
| ### Saving | ||
|
|
||
| ```{r} | ||
| ggsave("improved_bubble_map.png", improved_bubble_map, bg = "white", dpi = 300) | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this and other ggsave calls.
| font_add("LegendFont", "decimapro.ttf") # for legend | ||
| font_add("TitleFont", "sequel-sans-heavy-body.ttf") # for title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot publish fonts with copyrights. Please find some Google Fonts that are close enough and load them from there instead.
Draft pull request