Solo: a shared memory collective module #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thananon
requested changes
Oct 14, 2019
Collaborator
thananon
left a comment
thananon
left a comment
There was a problem hiding this comment.
I guess this is not the attempt to get to upstream right? Seems like there are some corner cases left unhandled.
bosilca
reviewed
Oct 14, 2019
bosilca
reviewed
Oct 21, 2019
ompi/mca/coll/solo/coll_solo.h
Outdated
| bool enabled; | ||
|
|
||
| /** | ||
| * osc alrogithms attach memory blocks to this bynamic window and use it to perform one-sided |
| &(static_size[i]), | ||
| &(static_disp[i]), | ||
| &(solo_module->ctrl_bufs[i])); | ||
| solo_module->data_bufs[i] = (char *) (solo_module->ctrl_bufs[i]) + 4 * opal_cache_line_size; |
There was a problem hiding this comment.
If the data_bufs are always a constant away (in this instance 4 cache lines) from the ctrl_bufs then instead of storing them you can easily compute them as needed.
…locate l_seg_count instead of count)
Known problems: 1. bcast: has bug if a datatype is from MPI_Bottom 2. reduce \ allreduce : fix or remove the non contiguous support.
|
I declined this in favor of #38. |
bosilca
added a commit
that referenced
this pull request
Sep 22, 2021
- Add support for fallback to previous coll module on non-commutative operations (#30) - Replace mutexes by atomic operations. - Use the correct nbc request type (for both ibcast and ireduce) * coll/base: document type casts in ompi_coll_base_retain_* - add module-wide topology cache - use standard instead of synchronous send and add mca parameter to control mode of initial send in ireduce/ibcast - reduce number of memory allocations - call the default request completion. - Remove the requests from the Fortran lookup conversion tables before completing and free it. Signed-off-by: George Bosilca <bosilca@icl.utk.edu> Signed-off-by: Joseph Schuchart <schuchart@hlrs.de> Co-authored-by: Joseph Schuchart <schuchart@hlrs.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.