-
Notifications
You must be signed in to change notification settings - Fork 0
[feat] Added Page Support #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
chrisvrose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the behaviour on the default API? Does it affect how the list API is called without arguments?
| var eventsList = eventsService.list(); | ||
| assertThat(eventsList).isNotNull().singleElement().isSameAs(event); | ||
| void testList() { | ||
| Pageable pageable = Pageable.ofSize(20).withPage(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use default Page size? instead of 20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default is 20
|
Unless you need additional objects in a single call, you can include query parameters like:
If no parameters are provided, it will return 20 events per request sorted in ascending order as |
|
Can we make the page size if both size and offset not applied as infinite(-1)? |
|
That should be possible let me check |
|
seems like there is no update on this from my side, I shall take this weekend to look at this issue |


also I ran default formatting in Intellij not sure why it has added/removed line breaks