Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

avoid crashing: when filter combine is already deinitialized, but still processing (weak==nil)#3

Open
elisar4 wants to merge 1 commit intoIGRSoft:masterfrom
elisar4:master
Open

avoid crashing: when filter combine is already deinitialized, but still processing (weak==nil)#3
elisar4 wants to merge 1 commit intoIGRSoft:masterfrom
elisar4:master

Conversation

@elisar4
Copy link

@elisar4 elisar4 commented Jan 5, 2019

I am getting crashed while doing simple steps:

  1. I have 2 view controllers first is main, second is filter controller
  2. present filter controller from main controller
  3. previews of filters are starting processing
  4. before processing complete click "close" button to dismiss filter controller
  5. callback "processedPreviewImagesCompletion" or "processedImagesCompletion" will now crash the app, when processing finished, because filter controller is already deallocated

The same issue could appear in all other callbacks with weak. These two are the most commonly used and with this commit it will not crash the app anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant