This repository was archived by the owner on May 6, 2020. It is now read-only.
avoid crashing: when filter combine is already deinitialized, but still processing (weak==nil)#3
Open
elisar4 wants to merge 1 commit intoIGRSoft:masterfrom
Open
avoid crashing: when filter combine is already deinitialized, but still processing (weak==nil)#3elisar4 wants to merge 1 commit intoIGRSoft:masterfrom
elisar4 wants to merge 1 commit intoIGRSoft:masterfrom
Conversation
…ll processing (weak==nil)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am getting crashed while doing simple steps:
The same issue could appear in all other callbacks with weak. These two are the most commonly used and with this commit it will not crash the app anymore.