Open
Conversation
- Add system case to ThemeMode enum that follows macOS appearance - Add effectiveMode property to resolve system mode to dark/light - Update theme mode toggle with system option (half-circle icon) - Update CodeEditorView, ExportPanelView to use effectiveThemeMode - Pass effective mode to export view for correct panel styling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Users want the theme to automatically switch between dark and light based on their macOS system appearance settings.
Changes
systemcase toThemeModeenum that follows macOS appearanceeffectiveModecomputed property that resolves system mode to dark/light based onNSApp.effectiveAppearanceCodeEditorView,ExportPanelView, andContentViewto useeffectiveThemeModefor colorsNotes
NSApp.effectiveAppearanceto determine current macOS appearance