Skip to content

UIComponent: Add PHP code for glyphs: select, unselect & clear #10829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lscharmer wants to merge 1 commit into
base: trunk
Choose a base branch
from
+30 −0
Open

UIComponent: Add PHP code for glyphs: select, unselect & clear #10829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions components/ILIAS/UI/src/Component/Symbol/Glyph/Glyph.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ interface Glyph extends Symbol, Clickable
public const DRAG_HANDLE = "dragHandle";
public const CHECKED = "checked";
public const UNCHECKED = "unchecked";
public const SELECT = 'select';
public const UNSELECT = 'unselect';
public const CLEAR = 'clear';

/**
* Get the type of the glyph.
Expand Down
15 changes: 15 additions & 0 deletions components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Factory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,4 +323,19 @@ public function unchecked(): G\Glyph
{
return new Glyph(G\Glyph::UNCHECKED, "unchecked");
}

public function select(): G\Glyph
{
return new Glyph(G\Glyph::SELECT, 'select');
}

public function unselect(): G\Glyph
{
return new Glyph(G\Glyph::UNSELECT, 'unselect');
}

public function clear(): G\Glyph
{
return new Glyph(G\Glyph::CLEAR, 'clear');
}
}
3 changes: 3 additions & 0 deletions components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Glyph.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ class Glyph implements C\Symbol\Glyph\Glyph
self::DRAG_HANDLE,
self::CHECKED,
self::UNCHECKED,
self::SELECT,
self::UNSELECT,
self::CLEAR,
];

private string $type;
Expand Down
3 changes: 3 additions & 0 deletions components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@
<!-- BEGIN dragHandle --> glyphicon-dragHandle<!-- END dragHandle -->
<!-- BEGIN checked --> glyphicon-checked<!-- END checked -->
<!-- BEGIN unchecked --> glyphicon-unchecked<!-- END unchecked -->
<!-- BEGIN select --> glyphicon-select<!-- END select -->
<!-- BEGIN unselect --> glyphicon-unselect<!-- END unselect -->
<!-- BEGIN clear --> glyphicon-clear<!-- END clear -->
" aria-hidden="true"></span>

<!-- BEGIN counter_status -->
Expand Down
6 changes: 6 additions & 0 deletions components/ILIAS/UI/tests/Component/Symbol/Glyph/GlyphTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ public function getCounterFactory(): C\Factory
G\Glyph::DRAG_HANDLE => "glyphicon glyphicon-dragHandle",
G\Glyph::CHECKED => "glyphicon glyphicon-checked",
G\Glyph::UNCHECKED => "glyphicon glyphicon-unchecked",
G\Glyph::SELECT => 'glyphicon glyphicon-select',
G\Glyph::UNSELECT => 'glyphicon glyphicon-unselect',
G\Glyph::CLEAR => 'glyphicon glyphicon-clear',
);

public static array $aria_labels = array(
Expand Down Expand Up @@ -169,6 +172,9 @@ public function getCounterFactory(): C\Factory
G\Glyph::DRAG_HANDLE => "drag_handle",
G\Glyph::CHECKED => "checked",
G\Glyph::UNCHECKED => "unchecked",
G\Glyph::SELECT => 'select',
G\Glyph::UNSELECT => 'unselect',
G\Glyph::CLEAR => 'clear',
);

#[\PHPUnit\Framework\Attributes\DataProvider('getGlyphTypeProvider')]
Expand Down