Skip to content

News 46626: Fixes TypeError in E-Learning Module #10833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukas-heinrich wants to merge 2 commits into
base: release_9
Choose a base branch
from
Open

News 46626: Fixes TypeError in E-Learning Module #10833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84100eb
fix: use news collection if no contexts provided to avoid "Argument #…
lukas-heinrich Jan 7, 2026
b97d805
fix: allow null values in withFetchCallback as object property may be…
lukas-heinrich Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Services/News/src/Data/LazyNewsCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ public function __construct(
}

/**
* @param \Closure(int[], string[]): NewsItem[] $callback
* @param null|\Closure(int[], string[]): NewsItem[] $callback
*/
public function withFetchCallback(\Closure $callback): static
public function withFetchCallback(?\Closure $callback): static
{
$clone = clone $this;
$clone->fetch_callback = $callback;
Expand Down
4 changes: 2 additions & 2 deletions Services/News/src/Persistence/NewsRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@ public function findByContextsBatch(array $contexts, NewsCriteria $criteria): Ne
/**
* @param NewsContext[] $contexts
*/
public function findByContextsBatchLazy(array $contexts, NewsCriteria $criteria): LazyNewsCollection
public function findByContextsBatchLazy(array $contexts, NewsCriteria $criteria): NewsCollection
{
if (empty($contexts)) {
return new LazyNewsCollection();
return new NewsCollection();
}

$obj_ids = array_map(fn($context) => $context->getObjId(), $contexts);
Expand Down