ULTRA L1b mask out invalid times

[lacoak21]

Change Summary

Overview

Event times should not be calculated for events at "valid_mask". These will have phase_angle fill vals and the event time calculation will be incorrect. The old code used to do this so I basically reverted back to how we used to compute them.

valid_mask = de_dataset["start_type"].data != FILLVAL_UINT8

Updated Files

• imap_processing/ultra/l1b/de.py
  • revert back code

[Copilot]

Pull request overview

This PR fixes the calculation of event times for ULTRA L1b data by excluding invalid events (where start_type equals the fill value) from the event time calculation. Invalid events have fill values for phase_angle, which would lead to incorrect event time calculations if processed. The fix reverts to the previous approach of pre-initializing event_times and spin_starts arrays with fill values and only calculating times for valid events.

Key Changes:

• Pre-initialize event_times and spin_starts arrays with fill values before selective calculation
• Modified get_event_times call to process only valid events (filtered by valid_mask)
• Updated valid_events logic to identify events with valid (non-fill) event times
• Adjusted repoint filtering to only process valid events and properly update masks

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[greglucas]

I don't think you need the initial copy since it is already creating a new array on that line.

The valid events of valid events is a bit confusing at first reading. Could use a comment about only updating where true or something like that.