Add permutations feature to DOSDP patterns schema#88
Open
Add permutations feature to DOSDP patterns schema#88
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a permutations feature to the DOSDP patterns schema, enabling automatic generation of additional annotations by permuting over annotation property values from filler terms. The feature supports generating the cartesian product when multiple permutation entries are specified.
- Adds a new
permutationschema definition with required fields for variable and annotation properties - Integrates permutations into both
printf_annotationandprintf_annotation_obodefinitions - Provides a test pattern demonstrating the feature usage
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/schema/dosdp_schema.yaml | Adds the permutation definition and integrates it into annotation schemas to enable synonym generation through permutations |
| src/schema/test/positive_test_set/patterns/acute_with_permutations.yaml | Provides a test pattern demonstrating the permutations feature for generating synonyms from disease exact_synonym values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added 'tabulate' and pinned 'jsonschema2md' version in setup.py to fix CI errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87