deployment: Add shared-data volume #73
Draft
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I mounted the shared-data folder to /shared-data because that's the default in the iqgeo-platform helm chart, so I tried to keep it consistent. |
mstrong98
reviewed
Oct 9, 2025
Contributor
There was a problem hiding this comment.
@paul-garster Thanks for this.
I ran through the changes in this branch and all seem to work. Just one thought mentioned in the comment attached to this review.
Edit: See my follow up review
Contributor
|
These containers run as www-data user. With that, the |
samfrances
force-pushed
the
devops/ET-729-shared-data
branch
from
e793b5c to
16afdf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For features such as upload Data, LRT needs to have shared_data between the appserver and workers.
The changes to the deployment/dockerfile are intended to introduce a name volume to act as this shared-data, and for the SHARED_DIRECTORY to be defined correctly to update configuration such as the upload_cache.
Due to problems with my local docker I haven't been able to test this stands up and performs correctly so I've left this PR in draft; however if you are able to test and verify the functionality, it's here so it can be merged into dev.