Task/plat 12806 add flock to entrypoints #75
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other services are initializing or upgrading database.
There was a problem hiding this comment.
Pull Request Overview
This PR adds distributed locking mechanisms to database initialization and upgrade scripts to prevent race conditions when multiple instances attempt to initialize or upgrade the database simultaneously. The scripts now use file-based locking with flock when a shared directory is available.
- Wraps existing database operations in functions to enable conditional execution
- Implements file-based locking using
flockwhenSHARED_DIRECTORYis configured - Falls back to direct execution when no shared directory is available
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| deployment/entrypoint.d/600_init_db.sh | Adds locking mechanism to database initialization to prevent concurrent initialization attempts |
| deployment/entrypoint.d/610_upgrade_db.sh | Adds locking mechanism to database upgrade to prevent concurrent upgrade attempts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for the entrypoint scripts to be run concurrently creating race conditions when the module databases are being initialized or upgraded. This PR locks those files so only one process can initialize or upgrade databases at a time. Similar to https://github.com/IQGeo/utils-docker-platform/pull/369 for the core database.