-
Notifications
You must be signed in to change notification settings - Fork 530
Prevent ExcludeEmailFromExport to hide the user email when an authorized user is obtaining metadata for editing a dataset #11819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
qqmyers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I made a couple suggestions for cleanup.
I also noticed that there is a Dataverses api call that also uses this setting - probably another case that will eventually need this override.
src/main/java/edu/harvard/iq/dataverse/util/json/JsonPrinter.java
Outdated
Show resolved
Hide resolved
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
qqmyers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - nice improvement to the DatasetFieldWalker!
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
What this PR does / why we need it: SPA needs to get the contact email to fill the edit screen even when the ExcludeEmailFromExport setting is set. Only for users calling the get dataset version API and the user has EditDataset permissions.
Which issue(s) this PR closes:#11714
Special notes for your reviewer:
Suggestions on how to test this: See DatasetIT test
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: