Engine Refactor #1: Basic Structure #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifying the NodeTypes by generalizing different operators into one OperatorNode model; Using Set semantics for most query structure's children; Making sure VarSQL variables use set semantics; Rewriting the tests accordingly;
baiqiushi
previously approved these changes
Oct 6, 2025
colinthebomb1
previously approved these changes
Oct 6, 2025
Collaborator
colinthebomb1
left a comment
colinthebomb1
left a comment
There was a problem hiding this comment.
LGTM, left one small comment
colinthebomb1
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a basic structure for the new query AST design. The structure can be divided into the following categories:
Node(abstract superclass for all nodes in the tree)TableNode,ColumnNode, etc.SelectNode,FromNode,WhereNode, etc.Todos (just for reference)
Join-related functionality. (after we have some unit tests)