Skip to content

Conversation

@julianbrost
Copy link
Member

@julianbrost julianbrost commented Dec 3, 2025

The Icinga 2 snapshot container images are no longer pushed as icinga/icinga2:master to Docker Hub but as icinga/icinga2:edge instead.

Tests

Before

Currently, the integration tests in the Icinga DB repo fail because the master tag was removed from Docker Hub: https://github.com/Icinga/icingadb/actions/runs/19881989563

panic: Error response from daemon: manifest for icinga/icinga2:master not found: manifest unknown: manifest unknown [recovered, repanicked]

After

Icinga/icingadb#1048 makes the Icinga DB repo use the code from this PR, the same integration tests pass again.

refs Icinga/icinga2#10505
refs https://icinga.com/blog/enhanced-icinga-2-container-images/

The Icinga 2 snapshot container images are no longer pushed as
`icinga/icinga2:master` to Docker Hub but as `icinga/icinga2:edge` instead.

Icinga/icinga2#10505
https://icinga.com/blog/enhanced-icinga-2-container-images/
@cla-bot cla-bot bot added the cla/signed label Dec 3, 2025
julianbrost added a commit to Icinga/icingadb that referenced this pull request Dec 3, 2025
…mage

The Icinga 2 snapshot container images are no longer pushed as
`icinga/icinga2:master` to Docker Hub but as `icinga/icinga2:edge` instead.

Icinga/icinga-testing#33
Icinga/icinga2#10505
https://icinga.com/blog/enhanced-icinga-2-container-images/
@yhabteab
Copy link
Member

yhabteab commented Dec 3, 2025

Dah, I forgot that we're still using that tag.

@julianbrost
Copy link
Member Author

So it's ultimately a good thing to remove the now obsolete tag so that we notice that we were referencing an image that's no longer updated.

@julianbrost julianbrost marked this pull request as ready for review December 3, 2025 10:20
@julianbrost julianbrost requested a review from yhabteab December 3, 2025 10:20
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ grep -nR 'icinga/icinga2:master' .
./internal/services/icinga2/docker.go:59:	dockerImage := utils.GetEnvDefault("ICINGA_TESTING_ICINGA2_IMAGE", "icinga/icinga2:master")
./it.go:7://   - ICINGA_TESTING_ICINGA2_IMAGE: Icinga 2 container image to use (default: "icinga/icinga2:master")
./it.go:243:// Each call to this function will spawn a dedicated Icinga 2 Docker container using the icinga/icinga2:master image.

@julianbrost julianbrost merged commit c399070 into main Dec 3, 2025
4 checks passed
julianbrost added a commit to Icinga/icingadb that referenced this pull request Dec 3, 2025
…mage

The Icinga 2 snapshot container images are no longer pushed as
`icinga/icinga2:master` to Docker Hub but as `icinga/icinga2:edge` instead.

Icinga/icinga-testing#33
Icinga/icinga2#10505
https://icinga.com/blog/enhanced-icinga-2-container-images/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants