Skip to content

fix(grid): remove unnecessary cell-select class from igx-select compo… #3851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mddragnev wants to merge 1 commit into
base: vnext
Choose a base branch
from
Open

fix(grid): remove unnecessary cell-select class from igx-select compo… #3851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/grid/grid-select/grid-select-sample.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
</igx-column>
<igx-column field="race" header="Race" [editable]="true">
<ng-template igxCellEditor let-cell="cell" let-value>
<igx-select class="cell-select" [(ngModel)]="cell.editValue" [igxFocus]="true">
<igx-select [(ngModel)]="cell.editValue" [igxFocus]="true">
@for (race of races; track race) {
<igx-select-item [value]="race">
{{ race }}
Expand All @@ -14,7 +14,7 @@
</igx-column>
<igx-column field="class" header="Class" [editable]="true">
<ng-template igxCellEditor let-cell="cell" let-value>
<igx-select class="cell-select" [(ngModel)]="cell.editValue" [igxFocus]="true">
<igx-select [(ngModel)]="cell.editValue" [igxFocus]="true">
@for (class of classes; track class) {
<igx-select-item [value]="class">
{{ class }}
Expand All @@ -27,7 +27,7 @@
</igx-column>
<igx-column field="alignment" header="Alignment" [editable]="true">
<ng-template igxCellEditor let-cell="cell" let-value>
<igx-select class="cell-select" [(ngModel)]="cell.editValue" [igxFocus]="true">
<igx-select [(ngModel)]="cell.editValue" [igxFocus]="true">
@for (alignment of alignments; track alignment) {
<igx-select-item [value]="alignment">
{{ alignment }}
Expand Down
5 changes: 0 additions & 5 deletions src/app/grid/grid-select/grid-select-sample.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,3 @@
display: block;
padding: 16px;
}

.cell-select {
width: 100%;
height: 100%;
}