020 implement data from new api #24

ImMPrada · 2022-08-29T16:46:44Z

This PR:

uses .env to store API endpoint into REACT_APP_API_ENDPOINT
upgrades useGithub hook for the new API endpoint and response data structure
upgrade components for the new response data structure

vercel · 2022-08-29T16:46:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
github-profile-viewer	✅ Ready (Inspect)	Visit Preview	Sep 1, 2022 at 8:35PM (UTC)

mapra99 · 2022-09-04T01:47:20Z

src/components/CardWithLegend/CardWithLegend.jsx

        <div className="card-label__head__legend">
          <div className="card-label__head__legend__info">
-            <h3>{state.profile.name}<br/><a href={state.profile.html_url}>@{state.profile.login}</a></h3>
+            <h3>{state.profile.name || 'no name user :('}<br/><a href={state.profile.url}>@{state.profile.login}</a></h3>


Suggested change

<h3>{state.profile.name || 'no name user :('}<br/><a href={state.profile.url}>@{state.profile.login}</a></h3>

<h3>{state.profile.name || 'No user name :('}<br/><a href={state.profile.url}>@{state.profile.login}</a></h3>

mapra99 · 2022-09-04T01:48:18Z

src/components/DataBox/DataBox.jsx

+        <p>Gists</p>
+        <p>{state.profile.publicGistsCount}</p>
      </div>
      <div className="data-box__info">
        <p>Followers</p>
-        <p>{state.profile.followers}</p>
+        <p>{state.profile.followersCount}</p>
      </div>
      <div className="data-box__info">
        <p>Following</p>
-        <p>{state.profile.following}</p>
+        <p>{state.profile.followingsCount}</p>


imo these <p> tags should be <span> because they are not actually paragraphs

mapra99 · 2022-09-04T01:48:33Z

src/components/GitCardFooter/GitCardFooter.jsx

+      <div className={`git-card-footer__element${state.profile.twitter ? '' : '-null'}`}>
        <Twitter /> 
-        <p>{state.profile.twitter_username || 'Not Available'}</p>
+        <p>{state.profile.twitter || 'Not Available'}</p>


mapra99 · 2022-09-04T01:49:15Z

src/components/ReposList/ReposList.jsx

    if(!reposList) setReposList(repos(state))
  }

+  if(state.repos) {


I think it would be easier to understand if you say

if (!state.repos) return null return ( THE COMPONENT )

instead of wrapping the actual component in a if clause and at the end return null in any other case

mapra99 · 2022-09-04T01:50:13Z

src/hooks/useGitHub/useGitHub.js

-          payload: curatedRepos,
-        })
+        const response = res.data
+        console.log(res.data)


remove console.log?

mapra99 · 2022-09-04T01:51:09Z

src/hooks/useGitHub/useGitHub.js

-        })
+        const response = res.data
+        console.log(res.data)
+        if(response.profile == null) {


Is it really necessary to use ==? Also is it necessary to compare with null? Is if(response.profile) enough?

Suggested change

if(response.profile == null) {

if(response.profile === null) {

codacy-production · 2022-09-29T01:58:26Z

src/components/ReposList/ReposList.jsx

  )
+  }
+
+  return null


Codacy has a fix for the issue: Insert ;

Suggested change

return null

return null;

codacy-production · 2022-09-29T01:58:27Z

src/components/ReposList/ReposList.jsx

    if(!reposList) setReposList(repos(state))
  }

+  if(state.repos) {


Codacy has a fix for the issue: Insert ·

Suggested change

if(state.repos) {

if (state.repos) {

codacy-production · 2022-09-29T01:58:28Z

src/hooks/useGitHub/useGitHub.js

-          type: 'RESULT_OF_REPOS',
-          payload: curatedRepos,
-        })
+        const response = res.data


Codacy has a fix for the issue: Insert ;

Suggested change

const response = res.data

const response = res.data;

codacy-production · 2022-09-29T01:58:30Z

src/components/ErrorMessage/ErrorMessage.jsx

  return (
    <div className = {`error-message`}>
-      <h4>ERROR!</h4>
+      <h4>{state.message ? `Error: ${state.message}` : 'ERROR!'}</h4>


Codacy has a fix for the issue: Replace 'ERROR!' with "ERROR!"

Suggested change

<h4>{state.message ? `Error: ${state.message}` : 'ERROR!'}</h4>

<h4>{state.message ? `Error: ${state.message}` : "ERROR!"}</h4>

codacy-production · 2022-09-29T01:58:31Z

src/js/reducer.js

-    repos: payload,
-  },
-  'ADD_REPO': {
+  'LOAD_RESULTS': {


Codacy has a fix for the issue: Replace 'LOAD_RESULTS' with LOAD_RESULTS

Suggested change

'LOAD_RESULTS': {

LOAD_RESULTS: {

codacy-production · 2022-09-29T01:58:33Z

src/hooks/useGitHub/useGitHub.js

-        })
+        const response = res.data
+        console.log(res.data)
+        if(response.profile == null) {


Codacy has a fix for the issue: Insert ·

Suggested change

if(response.profile == null) {

if (response.profile == null) {

codacy-production · 2022-09-29T01:58:34Z

src/hooks/useGitHub/useGitHub.js

+          })  
+        } else {
+          dispatch({
+            type: 'LOAD_RESULTS',


Codacy has a fix for the issue: Replace 'LOAD_RESULTS' with "LOAD_RESULTS"

Suggested change

type: 'LOAD_RESULTS',

type: "LOAD_RESULTS",

ImMPrada added 3 commits August 26, 2022 18:33

upgrade reducer and hook

3736de1

upgrade globalcontext

10e8986

upgrade components

e9c1d69

ImMPrada changed the title ~~020 implement data from new api~~ [WIP] 020 implement data from new api Aug 30, 2022

API was fixed, and serve the needed data

95760f9

vercel bot deployed to Preview September 1, 2022 20:18 View deployment

ImMPrada added 2 commits September 1, 2022 15:32

add .env.example

cb4b9a7

upgrade useGithub hook for consuming env variable

093f64d

vercel bot deployed to Preview September 1, 2022 20:34 View deployment

ImMPrada force-pushed the 020-implement-data-from-new-api branch from 101d513 to 093f64d Compare September 1, 2022 20:35

vercel bot deployed to Preview September 1, 2022 20:35 View deployment

ImMPrada requested a review from mapra99 September 1, 2022 20:40

ImMPrada changed the title ~~[WIP] 020 implement data from new api~~ 020 implement data from new api Sep 1, 2022

mapra99 reviewed Sep 4, 2022

View reviewed changes

src/hooks/useGitHub/useGitHub.js

payload: curatedRepos,

})

const response = res.data

console.log(res.data)

Copy link

Collaborator

mapra99 Sep 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log?

mapra99 reviewed Sep 4, 2022

View reviewed changes

codacy-production bot reviewed Sep 29, 2022

View reviewed changes

	<h3>{state.profile.name \|\| 'no name user :('}<br/><a href={state.profile.url}>@{state.profile.login}</a></h3>
	<h3>{state.profile.name \|\| 'No user name :('}<br/><a href={state.profile.url}>@{state.profile.login}</a></h3>

	if(response.profile == null) {
	if(response.profile === null) {

	<h4>{state.message ? `Error: ${state.message}` : 'ERROR!'}</h4>
	<h4>{state.message ? `Error: ${state.message}` : "ERROR!"}</h4>

	if(response.profile == null) {
	if (response.profile == null) {

020 implement data from new api #24

Are you sure you want to change the base?

020 implement data from new api #24

Uh oh!

Conversation

ImMPrada commented Aug 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Aug 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mapra99 Sep 4, 2022

Choose a reason for hiding this comment

Uh oh!

mapra99 Sep 4, 2022

Choose a reason for hiding this comment

Uh oh!

mapra99 Sep 4, 2022

Choose a reason for hiding this comment

Uh oh!

mapra99 Sep 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mapra99 Sep 4, 2022

Choose a reason for hiding this comment

Uh oh!

mapra99 Sep 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codacy-production bot Sep 29, 2022

Choose a reason for hiding this comment

Uh oh!

codacy-production bot Sep 29, 2022

Choose a reason for hiding this comment

Uh oh!

codacy-production bot Sep 29, 2022

Choose a reason for hiding this comment

Uh oh!

codacy-production bot Sep 29, 2022

Choose a reason for hiding this comment

Uh oh!

codacy-production bot Sep 29, 2022

Choose a reason for hiding this comment

Uh oh!

codacy-production bot Sep 29, 2022

Choose a reason for hiding this comment

Uh oh!

codacy-production bot Sep 29, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ImMPrada commented Aug 29, 2022 •

edited

Loading

vercel bot commented Aug 29, 2022 •

edited

Loading

mapra99 Sep 4, 2022 •

edited

Loading

mapra99 Sep 4, 2022 •

edited

Loading