-
Notifications
You must be signed in to change notification settings - Fork 0
Add GTM #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GTM #122
Conversation
Deploying isic-gallery with
|
| Latest commit: |
87cff89
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://44a7471c.isic-gallery.pages.dev |
| Branch Preview URL: | https://add-gtm-to-gallery.isic-gallery.pages.dev |
|
@EkaterinaPoddubskaya (and maybe @danlamanna) -- can you take a look at the vulnerability (audit) message? |
|
@neuroelf, this vulnerability message can be safely ignored because I resolved the issue in other PRs with |
|
OK. @danlamanna -- is there a way for me to confirm (other than the page loading) that it actually fires Google-Tag-Manager requests? I used an Chrome incognito tab, and looked at the Network tab of the Inspector window, and only saw the initial loading of the gtm.js script, but then no further requests being fired...? |
I don't think this PR is ready for review since it's in draft status. Is that right @EkaterinaPoddubskaya? |
|
Hi @danlamanna and @neuroelf - yes, this PR is still in draft status. It's not possible to see the results in your GA right now because I use my private gtm container to set everything up, test properly and not pollute your GA statistics with test data. When I finish it, I'm going to move these settings to your container and mark this PR ready for review. After you merge it, you'll be able to check it in realtime overview reports |
af6cd7a to
87cff89
Compare
This PR resolves issue #119