Skip to content

Conversation

@EkaterinaPoddubskaya
Copy link
Contributor

This PR resolves issue #119

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 18, 2025

Deploying isic-gallery with  Cloudflare Pages  Cloudflare Pages

Latest commit: 87cff89
Status: ✅  Deploy successful!
Preview URL: https://44a7471c.isic-gallery.pages.dev
Branch Preview URL: https://add-gtm-to-gallery.isic-gallery.pages.dev

View logs

@neuroelf
Copy link
Contributor

@EkaterinaPoddubskaya (and maybe @danlamanna) -- can you take a look at the vulnerability (audit) message?

@EkaterinaPoddubskaya
Copy link
Contributor Author

@neuroelf, this vulnerability message can be safely ignored because I resolved the issue in other PRs with npm audit, which updated both package.json and package-lock.json. So there is no need for npm audit to run here since the fixes will ultimately be merged into the master branch from those other branches

@neuroelf
Copy link
Contributor

OK. @danlamanna -- is there a way for me to confirm (other than the page loading) that it actually fires Google-Tag-Manager requests? I used an Chrome incognito tab, and looked at the Network tab of the Inspector window, and only saw the initial loading of the gtm.js script, but then no further requests being fired...?

@danlamanna
Copy link
Member

OK. @danlamanna -- is there a way for me to confirm (other than the page loading) that it actually fires Google-Tag-Manager requests? I used an Chrome incognito tab, and looked at the Network tab of the Inspector window, and only saw the initial loading of the gtm.js script, but then no further requests being fired...?

I don't think this PR is ready for review since it's in draft status. Is that right @EkaterinaPoddubskaya?

@EkaterinaPoddubskaya
Copy link
Contributor Author

Hi @danlamanna and @neuroelf - yes, this PR is still in draft status. It's not possible to see the results in your GA right now because I use my private gtm container to set everything up, test properly and not pollute your GA statistics with test data. When I finish it, I'm going to move these settings to your container and mark this PR ready for review. After you merge it, you'll be able to check it in realtime overview reports

@EkaterinaPoddubskaya EkaterinaPoddubskaya marked this pull request as ready for review June 20, 2025 15:13
@danlamanna danlamanna force-pushed the add-gtm-to-gallery branch from af6cd7a to 87cff89 Compare June 20, 2025 17:22
@danlamanna danlamanna merged commit eb09d38 into master Jun 20, 2025
3 checks passed
@danlamanna danlamanna deleted the add-gtm-to-gallery branch June 20, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants