-
Notifications
You must be signed in to change notification settings - Fork 0
Add source detail view with collect jobs list and enhance SourceCard navigation #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: xiaoland <37663413+xiaoland@users.noreply.github.com>
…translations Co-authored-by: xiaoland <37663413+xiaoland@users.noreply.github.com>
Co-authored-by: xiaoland <37663413+xiaoland@users.noreply.github.com>
… error handling Co-authored-by: xiaoland <37663413+xiaoland@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, please rename the newCollectJob component to collectJobForm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit 5b34ebb. The component has been renamed from newCollectJob to collectJobForm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use SourceCollectJobForm.parse({}) to create default form
- SourceCollectJob now has a new field
configand collectJobForm should provide a control to edit it. - remove create button and create event, this component should be a pure form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit 5b34ebb. Changes made:
- Now uses
SourceCollectJobForm.parse({})to create default form - Added
configfield to SourceCollectJob and collectJobForm with InkJsonEditor control - Removed create button and create event - component is now a pure form with v-model support
…rceForm component - Renamed newCollectJob component to collectJobForm - Updated collectJobForm to be a pure form component with config field support - Added config field to SourceCollectJob - Created sourceForm component extracted from createSource - Updated createSource to use sourceForm - Updated source detail view to use sourceForm with inline editing and save button - Used shallow: true for latestRunningJob in sourceCard - Added create button to new job popup Co-authored-by: xiaoland <37663413+xiaoland@users.noreply.github.com>
…dd error handling Co-authored-by: xiaoland <37663413+xiaoland@users.noreply.github.com>
… latestOpenJob - Created sourceCollectJobCard component for displaying job items - Renamed getLatestRunningBySource to getLatestOpenBySource - Updated method to include both PENDING and RUNNING statuses - Updated all references from latestRunningJob to latestOpenJob - Removed inline job-item styles in favor of component Co-authored-by: xiaoland <37663413+xiaoland@users.noreply.github.com>
…KCre/client-web into copilot/add-views-sources-index
Adds a dedicated detail view for sources (
/sources/:id) with inline editing, config management, and paginated collect jobs. Updates SourceCard to show open job status and enable navigation to detail view.Changes
Business Logic (
source.ts)getBySource(sourceId, {limit, offset, order})- fetch paginated collect jobs for a sourcegetLatestOpenBySource(sourceId)- get latest open job (PENDING or RUNNING) for a sourceconfigfield to SourceCollectJobSource Detail View (
views/sources/source/)sourceFormcomponent with all fields (nickname, type, config, collect schedule) and save buttonsourceCollectJobCardcomponent, job click → detail navigationcollectJobFormcomponent and create buttonsourceCollectJobCard Component (new)
collectJobForm Component (renamed from newCollectJob)
sourceForm Component (extracted from createSource)
createSourceand source detail view for consistencySourceCard Component
latestOpenJobto check for both PENDING and RUNNING jobs@click.stopon interactive elements to prevent navigation conflictsshallow: trueoptimizationRouter
/sources/collectJob/:idbefore/sources/:idto prevent route matching issuesLocalization
All components follow BEM naming, use design tokens, and include full documentation.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.