make type claim optional#54
Closed
hampsterx wants to merge 1 commit intoIndominusByte:masterfrom
hampsterx:make_type_claim_optional
Closed
make type claim optional#54hampsterx wants to merge 1 commit intoIndominusByte:masterfrom hampsterx:make_type_claim_optional
hampsterx wants to merge 1 commit intoIndominusByte:masterfrom
hampsterx:make_type_claim_optional
Conversation
rhatch-kw
reviewed
Feb 22, 2022
rhatch-kw
left a comment
rhatch-kw
left a comment
There was a problem hiding this comment.
This changes strikes me as a very good idea. I also have a need to validate JWT that does not originate from my app and therefore does not contain the type field in the payload.
Author
|
@IndominusByte any suggestion for better way to make "type" claim optional. Happy to update PR :) |
|
Hi, I've added more options to adjust type claims in #84. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#45
This PR is wrong (please decline it), but would like to raise the issue however :)
https://www.iana.org/assignments/jwt/jwt.xhtml#claims
"type" is not a reserved claim, in fact I found it hard to find (bit of a loaded keyword tho) any info about using "type" claim and could not find anything. Can it be made optional (setting perhaps?)