fix: fix missing assert in embedding.py #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我在实现embedinng的时候,错误地实现为1D的index数组永远只有一个元素,即只需要取一行。
运行embeding对应的测试文件
部分结果如下图:

测试程序按预期输出了不同的的部分,但是却意外地仍然输出 “Test passed!”
定位错误在出在函数 test_op_embedding中
没有对check_equal的返回值做任何处理,于是程序在测试出错的时候仍然非预期执行最后的输出
按照其他测试文件的风格,修改如下
程序按预期断言错误
