Conversation
KiranRajeev-KV
left a comment
There was a problem hiding this comment.
Hey! Thanks for sending the PR 😊
Just a small correction — the task is to:
- Create a file inside the
attendees/folder. - The file name should be your GitHub username, like:
attendees/your-github-username.py(or.c, if you're using C). - Inside the file, just print your name and roll number.
Right now:
It looks like your file is named something like attendees/Own Folder/file.py, which doesn't follow the required format.
What you need to do:
- Rename and move your file to match this pattern:
attendees/your-github-username.py
Let me know if you need help — happy to walk you through it!
|
Hello!
Just checked on the branches, Thank you so much for your review. I guess I lost track of it in the final stage. I tried making the changes and adding the file currently from VS code. But I just need clarification on the following, is it alright if I add the file directly from github. Looking forward for your guidance. Had great experience in the session.
Thank you.
…________________________________
From: Kiran Rajeev ***@***.***>
Sent: Wednesday, July 2, 2025 9:59 PM
To: KiranRajeev-KV/git-github-workshop ***@***.***>
Cc: LAKSHANYA B - [CB.SC.U4CSE24025] ***@***.***>; Author ***@***.***>
Subject: Re: [KiranRajeev-KV/git-github-workshop] Add lakshanya (PR #30)
You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
@KiranRajeev-KV requested changes on this pull request.
Hey! Thanks for sending the PR 😊
Just a small correction — the task is to:
1. Create a file inside the attendees/ folder.
2. The file name should be your GitHub username, like:
attendees/your-github-username.py (or .c, if you're using C).
3. Inside the file, just print your name and roll number.
Right now:
It looks like your file is named something like attendees/Own Folder/file.py, which doesn't follow the required format.
What you need to do:
* Rename and move your file to match this pattern:
attendees/your-github-username.py
Let me know if you need help — happy to walk you through it!
—
Reply to this email directly, view it on GitHub<#30 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMH32T6CP5XLP6REG6XEVWT3GQCIJAVCNFSM6AAAAACAT6YXWWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNZZHA2TIOJVGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
[https://intranet.cb.amrita.edu/sig/RankingLogo.png]
Disclaimer<https://intranet.cb.amrita.edu/sig/Disclaimer.htm>
|
|
Hi @lucks07 Thanks again for your update, and apologies for the 1-day delay in reviewing your PR — really appreciate your patience! Just a quick clarification: instead of adding the file directly on GitHub, please make the changes locally using VS Code (or your preferred editor), then push the updated commit. Here’s what needs to be done: Rename the file:
Move the file:
Delete the Final structure should look like this: After making these changes, please make sure to add, commit, and push them to update your PR. Once you've pushed the changes, let me know — I’ll review it right away! |
NAME-LAKSHANYA
ROLLNO-CB.SC.U4CSE24025