Skip to content

Conversation

@bkarli
Copy link

@bkarli bkarli commented Nov 19, 2023

No description provided.

Copy link
Contributor

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hash seems to be unknown. Did you use your university mail address?

@bkarli
Copy link
Author

bkarli commented Nov 20, 2023

Yes I did. Using zsh the hash created is not in the in the hashes.txt file. I've seen that you already made a change in the submit.sh script prompting the user to use bash. Using bash the outcoming hash is indeed in the file. So I'll make another commit.

Copy link
Contributor

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is interesting that the hash differs depending on the Shell being used, especially that zsh vs. bash makes a difference. However, the script has a hashbang indicating that it should be executed using bash.

The hash is now valid, but you have deleted the .gitkeep file. Please undo this and it should be fine to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants