Skip to content

Conversation

@maxim-inj
Copy link

@maxim-inj maxim-inj commented Sep 7, 2024

Need to evaluate and backport some or all fixes from the upstream.

  • Problem: gasWanted is not aligned for process proposal mode (#773438) ⚠️
  • Problem: no way to disable nonce checking in benchmark (#f9cd15)
  • Problem: no MaxTx set from config for mempool (#e5b222)
  • Problem: insufficient invalid value check in eth transaction (#45ac08)
  • Problem: incarnation cache not enabled (#9c959a)
  • Problem: no overflow check when add gasLimit to gasWanted (#d874df) ⚠️
  • Problem: invalid chain id for signer (#f3e62c) ⚠️
  • Problem: benchmark logic don't increase nonce (#350955)
  • Problem: cometbft not up to date (#c36b26)
  • Problem: disable of create vesting account messages are not complete (#b0022e)
  • Optimize AnteHandle method to skip checks if disabledMsgs is empty (#ff4caa)
  • Problem: vote_extensions is not disabled in test (#0e0baa)
  • Problem: no debug files uploaded when timeout in ci (#e3b813)
  • Problem: nondeterministic account set occurs with more stm workers (#7ef8af)
  • Problem: unnecessary GetAccount in ante handlers (#fe3f4f)
  • Problem: handle for integer overflow is messy (#d26ada) ⚠️
  • Problem: method eth_chainId crashed occasionally(#452b0c) ⚠️
  • Problem: hash in subscribe newHeads differs from eth_getBlockByNumber (#3fabdbe) ⚠️
  • Problem: block-stm tx executor bad worst case performance (#79bb39e)
  • Problem: pre-estimation don't run in parallel (#56f8a5)
  • Problem: tx evm raw doesn't work under offline (#dbc7eb4)
  • Problem: get unnecessary block result when only need header (#7e30762)
  • Problem: trace block gas refund change not committed (#bcac9e2) ⚠️
  • Problem: db is double closed when shutdown (#f2a562b) ⚠️
  • Problem: no time in Transaction (#9755333) ⚠️
  • Problem: multisig account failed on threshold encode after send tx #33e3cc6
  • Problem: dependencies are outdated #5acb559
  • Problem: get unnecessary block result in header related api call #b16b489
  • Problem: unsuppored sign mode SIGN_MODE_TEXTUAL in bank transfer #c4cef0f
  • Problem: validation broke after transaction conversion with raw field #617eac9
  • Problem: opBlockhash broke after sdk50 #853e1e5 ⚠️
  • Problem: default headerHashNum is too large #580ce6e ⚠️
  • Problem: no header hash from fallback historicalInfo #a2ad87c ⚠️
  • Problem: node can't quit by signal #816389c ⚠️

Additional issues

  • Problem: reverted Evm call doesn't revert Tx, other msgs in Tx still execute ⚠️
  • Problem: fee collector account failed to refund fees: the check always considers that 100% of gas is refundable
  • Problem: need to support eth_getBlockReceipts see Get receipts by block number ethereum/go-ethereum#19634 ⚠️

mmsqe and others added 15 commits June 26, 2024 20:26
* Problem: gasWanted is not aligned for process proposal mode

* check maxGasWanted
Solution:
- add unsafe option to turn off nonce checking
* Problem: no MaxTx set from config for mempool

* Update config.go

Co-authored-by: yihuang <huang@crypto.com>
Signed-off-by: mmsqe <mavis@crypto.com>

---------

Signed-off-by: mmsqe <mavis@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
* Problem: incarnation cache not enabled

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* cache eth sig verification result

* fix concurrent incarnations

* update deps

---------

Signed-off-by: yihuang <huang@crypto.com>
Solution:
- keep the benchmark logic closer to real one, only removing the nonce
  check part
…506)

* Problem: disable of create vesting account messages are not complete

* Update CHANGELOG.md

Signed-off-by: mmsqe <mavis@crypto.com>

---------

Signed-off-by: mmsqe <mavis@crypto.com>
)

* Optimize AnteHandle method to skip checks if disabledMsgs is empty

* Problem: cometbft not up to date (#505)

include the fix from cometbft/cometbft#3196

* Problem: disable of create vesting account messages are not complete (#506)

* Problem: disable of create vesting account messages are not complete

* Update CHANGELOG.md

Signed-off-by: mmsqe <mavis@crypto.com>

---------

Signed-off-by: mmsqe <mavis@crypto.com>

* CHANGELOG

* Update CHANGELOG.md

Signed-off-by: mmsqe <mavis@crypto.com>

---------

Signed-off-by: mmsqe <mavis@crypto.com>
Signed-off-by: fx0x55 <80245546+fx0x55@users.noreply.github.com>
Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Co-authored-by: mmsqe <mavis@crypto.com>
* Problem: vote_extensions is not disabled in test

* bump sdk
* Problem: no debug files uploaded when timeout in ci

30mins for marked, 1h for all in pytest

* Apply suggestions from code review

* set both
)

* rename

* pytest -v -s test_debug_traceblock.py

* follow existing practice

* update test

* update stm

* test

* add timeout

* disable

* revert

* fix

* update deps

---------

Co-authored-by: huangyi <huang@crypto.com>
* Problem: unnecessary GetAccount in ante handlers

reuse account after verify account balance to avoid get again when check sender sequence

* rename

* less MakeSigner

* cast string

* cleanup

* fix test

* fix lint

* cleanup

* cleanup test

* rm prefix

* fix

* fix test, account created automatically

* rename

* fix comment

* Apply suggestions from code review

Signed-off-by: yihuang <huang@crypto.com>

* cleanup

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: huangyi <huang@crypto.com>
@maxim-inj maxim-inj self-assigned this Sep 7, 2024
@coderabbitai
Copy link

coderabbitai bot commented Sep 7, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@maxim-inj maxim-inj changed the title Backport upstream changes [WIP] Backport upstream changes Sep 7, 2024
mmsqe and others added 12 commits September 10, 2024 11:46
* Problem: method eth_chainId crashed occasionally

add fallback default config to ensure no panic in IsEIP155 check

* cleanup

---------

Co-authored-by: huangyi <huang@crypto.com>
…#521)

* Problem: hash in subscribe newHeads differs from eth_getBlockByNumber

* fix test

* cleanup
* Problem: block-stm tx executor don't do simple static dependency
analysis

Solution:
- estimate dependencies based on tx fee payer, try to optimise worst case
  performance.

* fix build

* customize estimates instead of dependencies

* fix context

* update api

* cleanup

* changelog

* cleanup

* cleanup

* cleanup

* pre-estimate config

* fix lint
* Problem: pre-estimation don't run in parallel

* fix build

* fix race

* cleanup chunking

* keep unchanged

---------

Co-authored-by: mmsqe <mavis@crypto.com>
* Problem: trace block not accurate for dynamic fee transaction

fix

changelog

temp

* Update x/evm/keeper/state_transition.go

Signed-off-by: yihuang <huang@crypto.com>

* avoid mutate config tracer

* fix test

* adjust test

* more test

* resolve

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
* Problem: db is double closed when shutdown

* fix standAlone
* Problem: no time in Transaction

* update deps
)

* Problem: marshal error get overwritten by unexpected end of JSON input

* test multisig

* fix threshold encode

* pass

* update deps
* Problem: dependencies are outdated

* bump cometbft ibc

* cleanup

* fix build
dependabot bot and others added 30 commits October 15, 2025 07:07
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 5 to 6.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: randy-cro <randy.ang@crypto.com>
Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v7...v8)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: '8'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump github.com/onsi/ginkgo/v2 from 2.26.0 to 2.27.1

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.26.0 to 2.27.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.26.0...v2.27.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-version: 2.27.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: update gomod2nix.toml

* chore: verified commit for merge

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Randy Ang <randy.ang@crypto.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4...v5)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.27.1 to 2.27.2.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.27.1...v2.27.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-version: 2.27.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…18.1 in the go_modules group across 1 directory (#769)

* build(deps): bump github.com/consensys/gnark-crypto

Bumps the go_modules group with 1 update in the / directory: [github.com/consensys/gnark-crypto](https://github.com/consensys/gnark-crypto).


Updates `github.com/consensys/gnark-crypto` from 0.16.0 to 0.18.1
- [Release notes](https://github.com/consensys/gnark-crypto/releases)
- [Changelog](https://github.com/Consensys/gnark-crypto/blob/v0.18.1/CHANGELOG.md)
- [Commits](Consensys/gnark-crypto@v0.16.0...v0.18.1)

---
updated-dependencies:
- dependency-name: github.com/consensys/gnark-crypto
  dependency-version: 0.18.1
  dependency-type: indirect
  dependency-group: go_modules
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: update gomod2nix.toml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Randy Ang <randy.ang@crypto.com>
* apply state override to eth call

* fix changelog

* fix lint
Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.7.0 to 1.7.2.
- [Release notes](https://github.com/cosmos/gogoproto/releases)
- [Changelog](https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md)
- [Commits](cosmos/gogoproto@v1.7.0...v1.7.2)

---
updated-dependencies:
- dependency-name: github.com/cosmos/gogoproto
  dependency-version: 1.7.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Randy Ang <randy.ang@crypto.com>
Bumps [github.com/btcsuite/btcd](https://github.com/btcsuite/btcd) from 0.24.2 to 0.25.0.
- [Release notes](https://github.com/btcsuite/btcd/releases)
- [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES)
- [Commits](btcsuite/btcd@v0.24.2...v0.25.0)

---
updated-dependencies:
- dependency-name: github.com/btcsuite/btcd
  dependency-version: 0.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Randy Ang <randy.ang@crypto.com>
Bumps the npm_and_yarn group with 1 update in the /tests/integration_tests/hardhat directory: [js-yaml](https://github.com/nodeca/js-yaml).


Updates `js-yaml` from 4.1.0 to 4.1.1
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.1.0...4.1.1)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.1.1
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#785)

Bumps [actions/create-github-app-token](https://github.com/actions/create-github-app-token) from 2.1.4 to 2.2.0.
- [Release notes](https://github.com/actions/create-github-app-token/releases)
- [Commits](actions/create-github-app-token@6701853...7e473ef)

---
updated-dependencies:
- dependency-name: actions/create-github-app-token
  dependency-version: 2.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas <81727899+thomas-nguy@users.noreply.github.com>
…752)

* build(deps): bump github.com/cosmos/ibc-go/v10 from 10.1.1 to 10.4.0

Bumps [github.com/cosmos/ibc-go/v10](https://github.com/cosmos/ibc-go) from 10.1.1 to 10.4.0.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/main/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v10.1.1...v10.4.0)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v10
  dependency-version: 10.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: update gomod2nix.toml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* add check on evm tx tip

* add changelog

* fix nil check
Bumps alpine from 3.22.2 to 3.23.0.

---
updated-dependencies:
- dependency-name: alpine
  dependency-version: 3.23.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.10.1 to 1.10.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas <81727899+thomas-nguy@users.noreply.github.com>
* feat: use golang 1.25.0

* update go 1.25.0

* update golangci-lint

* fix apple_sdk_11_0 errors

* update nix build

* fix rpc test

* fix ci:

* add changelog

* single source of truth for gomod2nix
* support create_access_list

* add changelog

# Conflicts:
#	CHANGELOG.md

* fix lint

* make gas limit consistant

* fix conflict

* rework

* cleaning

* fix pointer

* add log

* add log

* fix response

* fix logic

* remove debug

* fix comments

* minor improvement
#804)

* fix: add AllowUnprotectedTxs configuration option to JSON-RPC settings

* doc: changelog

* test:

---------

Signed-off-by: Xinyu <91446598+XinyuCRO@users.noreply.github.com>
…805)

Bumps google.golang.org/protobuf from 1.36.10 to 1.36.11.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-version: 1.36.11
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: randy-cro <randy.ang@crypto.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 6.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v5...v6)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.25.0-alpine to 1.25.5-alpine.

---
updated-dependencies:
- dependency-name: golang
  dependency-version: 1.25.5-alpine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas <81727899+thomas-nguy@users.noreply.github.com>
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.28.0 to 0.32.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.28.0...v0.32.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-version: 0.32.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas <81727899+thomas-nguy@users.noreply.github.com>
…#796)

Bumps [actions/create-github-app-token](https://github.com/actions/create-github-app-token) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/actions/create-github-app-token/releases)
- [Commits](actions/create-github-app-token@7e473ef...29824e6)

---
updated-dependencies:
- dependency-name: actions/create-github-app-token
  dependency-version: 2.2.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas <81727899+thomas-nguy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants