Merged
Conversation
roninsightrx
commented
Jul 12, 2025
|
|
||
| # Check column names are lowercase | ||
| expect_equal(names(result), c("t", "obs_type", "y")) | ||
| expect_equal(names(result), c("t", "obs_type", "y", "obs_type")) |
Contributor
Author
There was a problem hiding this comment.
this is a bit ugly to end up with two columns with same name (if using OBS_TYPE as label), but this was how it was working before, we just didn't have a test on it. Don't want to change more than needed in this PR, we can tackle later.
| # Check sorting | ||
| expect_equal(result$t, c(1, 2, 3)) | ||
| expect_equal(result$obs_type, c(1, 1, 1)) | ||
| expect_equal(result$obs_type, c(1, 2, 1)) |
Contributor
Author
There was a problem hiding this comment.
this was wrong when I set up the test, didn't notice then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was just order of things: in the function I split off (parse_input_data), the obs_type_label needs to be handled before the colnames are all converted to lower-case.
I merged this off of tag
v1.74, so should just retag 1.74 tag to the SHA for this commit, no need to merge this PR (fix is already in master).