Merged
Conversation
mccarthy-m-g
reviewed
Sep 9, 2025
mccarthy-m-g
left a comment
mccarthy-m-g
left a comment
There was a problem hiding this comment.
Would this approach also work? It's a bit cleaner and more general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the edge case where it was possible to have duplicate
obs_typecolumns in the return object fromparse_input_data().It's still a bit ugly to have a specific line of code to set OBS_TYPE to NULL to avoid an edge case, but I think this is the simplest solution. The other solution is to not care about the edge case (it essentially only occurs with erroneous usage).
Very minor change, shouldn't affect any production code.