Remove pharmr/pharmpy functionality into its own repository#55
Merged
roninsightrx merged 6 commits intomainfrom Feb 5, 2026
Merged
Remove pharmr/pharmpy functionality into its own repository#55roninsightrx merged 6 commits intomainfrom
roninsightrx merged 6 commits intomainfrom
Conversation
roninsightrx
changed the title
roninsightrx
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the luna package by moving all Pharmpy/pharmr-related functionality into a separate repository (pharmr.extra). This reduces the scope of luna to focus on workflow management.
Changes:
- Removed all Pharmpy/pharmr-specific functions and tests (model creation, table handling, parameter estimation, etc.)
- Added pharmr.extra and irxutils as dependencies
- Updated function calls in remaining luna code to use pharmr.extra:: namespace
- Added a dummy test file to maintain test infrastructure
Reviewed changes
Copilot reviewed 181 out of 181 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| R/luna_run.R | Updated to call pharmr.extra::run_nlme |
| R/luna_check.R | Updated to call pharmr.extra::run_nlme |
| R/luna_tool.R | Updated to call pharmr.extra::prepare_run_folder and parse_psn_args |
| R/luna_compare.R | Updated to call pharmr.extra::compare_nlme_fit |
| R/luna_diff.R | Fixed internal function call, removed ::: notation |
| R/luna_list.R | Fixed cli function calls |
| R/luna-package.R | Added package documentation with imports |
| DESCRIPTION | Added pharmr.extra and irxutils dependencies, moved packages to Suggests |
| NAMESPACE | Removed exported functions, added import statements |
| tests/testthat/test-dummy.R | Added placeholder test |
| Multiple R and test files | Deleted files related to Pharmpy/pharmr functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mccarthy-m-g
approved these changes
Jan 29, 2026
Contributor
mccarthy-m-g
left a comment
mccarthy-m-g
left a comment
There was a problem hiding this comment.
A few things to clean up (comment below, missing comma in DESCRIPTION caught by copilot, and a merge conflict), otherwise lgtm!
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scope of
lunawas slowly gaining more and more features that were outside its central scope (workflow management). This PR separates off the code that deals with Pharmpy/pharmr into its own repository. This ensures easier and more structured development.Other than a few cleanup things, there are no functional changes in this PR.