This repository was archived by the owner on Jul 9, 2019. It is now read-only.
Open
Conversation
kgururaj
reviewed
Jun 19, 2017
| sa.UniqueConstraint('field_set_id', 'field', | ||
| name='unique_name_per_field_set_constraint'), | ||
| ) | ||
| type = sa.Column(sa.Enum('Integer', 'String', 'Float', 'Flag', name='type_enum')) |
| is_filter = sa.Column(sa.Boolean, nullable=False) | ||
| is_format = sa.Column(sa.Boolean, nullable=False) | ||
| is_info = sa.Column(sa.Boolean, nullable=False) | ||
| length_type = sa.Column(sa.Enum('A', 'R', 'G', 'VAR', 'NUM', name='length_enum')) |
metadb/models/field.py
Outdated
| is_format = sa.Column(sa.Boolean, nullable=False) | ||
| is_info = sa.Column(sa.Boolean, nullable=False) | ||
| length_type = sa.Column(sa.Enum('A', 'R', 'G', 'VAR', 'NUM', name='length_enum')) | ||
| length_intval = sa.Column(sa.Integer) |
| except exc.DataError as e: | ||
| self.session.rollback() | ||
| raise ValueError("{0} : {1} ".format(str(e), guid)) | ||
|
|
There was a problem hiding this comment.
Can we add an if statement if( reader) surrounding all the reader statements? ie. allow calling registerFieldSet with reader=None.
Author
|
@kgururaj - Of the 4 suggestions, the first two could not be implemented. There is at least one field |
|
Were these the FILTER fields with no length and type attributes? |
Author
|
Yes karthik. Filter fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kgururaj - committed schema changes
FYI - @kdatta