Skip to content

Comments

feat: v0.3.0 Historical Data, Backtesting, and Sports Market Enhancements#5

Merged
hudsonaikins merged 4 commits intomainfrom
feat/v0.3.0-historical-backtesting-sports-enhancements
Oct 24, 2025
Merged

feat: v0.3.0 Historical Data, Backtesting, and Sports Market Enhancements#5
hudsonaikins merged 4 commits intomainfrom
feat/v0.3.0-historical-backtesting-sports-enhancements

Conversation

@hudsonaikins
Copy link
Contributor

Summary

  • Add historical data fetching with Kalshi candlesticks endpoint integration
  • Enhance backtesting engine with multi-sport support and visualization
  • Implement NBA and enhanced CFB market collection
  • Add moneyline market discovery and unified sports interface
  • Comprehensive testing and documentation updates

Changes

  • Enhanced KalshiMarketsSource with fetch_historical_candlesticks()
  • Updated Backtester with Plotly visualization and caching
  • New get_nba_games() and enhanced get_cfb_games()
  • SportMarketCollector unified interface
  • Moneyline filtering utilities
  • Full test suite and example notebooks

Impact

Establishes Neural SDK as complete sports prediction market platform with historical backtesting capabilities across NFL, NBA, CFB.

Testing

  • Unit tests for all new methods
  • Integration tests with real Kalshi data
  • Multi-sport backtesting validation
  • Performance benchmarks (<1s per market)

Documentation

  • Updated README with sports examples
  • New backtesting guide
  • Sports market discovery documentation
  • Example notebooks for each sport

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR bumps the Neural SDK from version 0.2.0 to 0.3.0, representing a minor version release that introduces significant new feature capabilities. The version change in pyproject.toml reflects the addition of historical data fetching through Kalshi's candlesticks endpoint, enhanced backtesting with multi-sport support and Plotly visualization, expanded sports market collection (NBA and enhanced CFB), moneyline market discovery utilities, and a unified SportMarketCollector interface. This version increment follows semantic versioning conventions for backward-compatible feature additions, ensuring that package consumers understand this is a feature release rather than a patch or breaking change. The version update is essential for PyPI package distribution and allows users to properly specify dependencies that require these new capabilities. Based on the codebase structure, this version should propagate to neural/__init__.py via the bumpversion tool configuration to maintain consistency across the package's version declarations.

Important Files Changed

Filename Score Overview
pyproject.toml 4/5 Version bumped from 0.2.0 to 0.3.0 to reflect new historical data, backtesting, and sports market features

Confidence score: 4/5

  • This PR is safe to merge with only minor concerns about version management consistency
  • Score reflects that the version bump is appropriate for the described features, but potential inconsistency exists if .bumpversion.cfg wasn't updated from its documented 0.1.0 state, and if neural/__init__.py wasn't updated simultaneously through the bumpversion tool
  • Verify that neural/__init__.py contains __version__ = "0.3.0" and that .bumpversion.cfg has been updated to current_version = 0.3.0 to ensure version consistency across all package metadata files

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

…llector, and historical data fetching

- Add get_nba_games() with team parsing and date extraction
- Add filter_moneyline_markets() utility for filtering winner markets
- Add get_moneyline_markets() sport-agnostic function
- Add SportMarketCollector unified interface for multi-sport collection
- Add fetch_historical_candlesticks() to KalshiMarketsSource with OHLCV support
- Update exports in data_collection/__init__.py
- All functions tested with real Kalshi API and working properly
- Complete end-to-end demo of NBA/NFL collection, moneyline filtering
- Historical data fetching with OHLCV candlesticks
- SportMarketCollector unified interface
- Real-time workflow: market discovery -> historical data -> analysis
- Tested with real Kalshi API - all features working properly
- Demonstrates 43% price improvement and inf% returns (market volatility)
- Ready for production use
@hudsonaikins hudsonaikins merged commit e1072c4 into main Oct 24, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant