[Fix] Fix the import bug in the training script #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzcai99
approved these changes
Oct 31, 2025
…ix habitat config dataset path
Tai-Wang
reviewed
Nov 3, 2025
scripts/train/train.py
Outdated
| from internnav.model.basemodel.cma.cma_policy import CMAModelConfig, CMANet | ||
| from internnav.model.basemodel.navdp.navdp_policy import NavDPModelConfig, NavDPNet | ||
| from internnav.model.basemodel.rdp.rdp_policy import RDPModelConfig, RDPNet | ||
| from internnav.model.basemodel.seq2seq.seq2seq_policy import ( |
Collaborator
There was a problem hiding this comment.
Recommend simplifying the "from xxxx" by adding init under the folder basemodel or cma/navdp...
Tai-Wang
approved these changes
Nov 3, 2025
Tai-Wang
changed the title
heyi301
pushed a commit
to heyi301/InternNav
that referenced
this pull request
Dec 16, 2025
* fix train import bug * updated to latest doc; fix meaningless sys path append in train.py; fix habitat config dataset path * update import in train.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an import error in scripts/train/train.py in line17 caused by the recent dependency isolation refactor.
Previously, the script imported model directly, but after modularizing dependencies, that import is no longer valid.
Changes:
Replaced the outdated import model with explicit imports from each model submodule. Ensured compatibility with the new isolated dependency structure.
Update:
update habitat evaluation config dataset path to match current InternData-N1
Test with the latest documents. Ensured all scripts matching the dataset directory and guideline.