Skip to content

Worsen file 2 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IrmaKarasoftic wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Worsen file 2 #29

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37ae967
worsen the file
IrmaKarasoftic Sep 4, 2023
1ea70bd
small change
IrmaKarasoftic Sep 7, 2023
2bc19cf
Added directive
IrmaKarasoftic Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion SynonymsAPI/Services/BadService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ public bool Add_Test_123(string word)

}
}
else if (word == "C")
else if (word == "A")
Copy link

@codescene-staging-delta-analysis codescene-staging-delta-analysis bot Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ Getting worse: Code Duplication
introduced similar code in: Calculate

Why does this problem occur?

Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health. Read more.

To ignore this warning click here.

Copy link

@codescene-staging-delta-analysis codescene-staging-delta-analysis bot Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 9.25 to 9.29, threshold = 4

Why does this problem occur?

This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals. Read more.

To ignore this warning click here.

Copy link

@codescene-staging-delta-analysis codescene-staging-delta-analysis bot Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ Getting worse: Primitive Obsession
The ratio of primitive types in function arguments increases from 96.55% to 97.14%, threshold = 30.0%

Why does this problem occur?

The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments. Read more.

To ignore this warning click here.

Copy link

@codescene-staging-delta-analysis codescene-staging-delta-analysis bot Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ New issue: Excess Number of Function Arguments
Calculate has 5 arguments, threshold = 4

Why does this problem occur?

This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments. Read more.

To ignore this warning click here.

Copy link

@codescene-staging-delta-analysis codescene-staging-delta-analysis bot Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No longer an issue: String Heavy Function Arguments
The ratio of strings in function arguments is no longer above the threshold

{
if (word == "BA")
{
Expand All @@ -479,12 +479,54 @@ public bool Add_Test_123(string word)
}
return true;
}

catch (Exception)
{
return false;
}
}

public decimal Calculate(decimal amount, int type, int years, bool foo1, bool foo2, bool foo3)
{
decimal result = 0;
decimal disc = (years > 5) ? (decimal)5 / 100 : (decimal)years / 100;
if (type == 1)
{
result = amount;
if (type == 1)
{
result = amount;
}
else if (type == 2)
{
result = (amount - (0.1m * amount)) - disc * (amount - (0.1m * amount));
}
else if (type == 3)
{
result = (0.7m * amount) - disc * (0.7m * amount);
}
else if (type == 4)
{
result = (amount - (0.5m * amount)) - disc * (amount - (0.5m * amount));
}
return result;
}
else if (type == 2)
{
result = (amount - (0.1m * amount)) - disc * (amount - (0.1m * amount));
}
else if (type == 3)
{
result = (0.7m * amount) - disc * (0.7m * amount);
}
else if (type == 4)
{
result = (amount - (0.5m * amount)) - disc * (amount - (0.5m * amount));
}
return result;
}
Comment on lines +489 to +527
Copy link

@codescene-staging-delta-analysis codescene-staging-delta-analysis bot Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ New issue: Complex Method
Calculate has a cyclomatic complexity of 10, threshold = 9

Why does this problem occur?

This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring. Read more.

To ignore this warning click here.

Comment on lines +489 to +527
Copy link

@codescene-staging-delta-analysis codescene-staging-delta-analysis bot Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ Getting worse: Excess Number of Function Arguments
Calculate increases from 5 to 6 arguments, threshold = 4

Why does this problem occur?

This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments. Read more.

To ignore this warning click here.


@CodeScene(disable:\"Complex Method\")
public decimal Calculate(decimal amount, int type, int years)
{
decimal result = 0;
Expand Down