Open
Conversation
![codescene-staging-delta-analysis[bot]](https://avatars.githubusercontent.com/in/52858?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: SomeOtherMethod
- Code Duplication SynonymsServiceWithDirective.cs
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
✅ Positive Code Health Impact (highest to lowest):
- Large Method SynonymsServiceWithDirective.cs: Add
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Positive Code Health Impact (highest to lowest):
- Large Method SynonymsServiceWithDirective.cs: Add
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Positive Code Health Impact (highest to lowest):
- Large Method SynonymsServiceWithDirective.cs: Add
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Positive Code Health Impact (highest to lowest):
- Large Method SynonymsServiceWithDirective.cs: Add
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Positive Code Health Impact (highest to lowest):
- Large Method SynonymsServiceWithDirective.cs: Add
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Positive Code Health Impact (highest to lowest):
- Large Method SynonymsServiceWithDirective.cs: Add
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Positive Code Health Impact (highest to lowest):
- Large Method SynonymsServiceWithDirective.cs: Add
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Positive Code Health Impact (highest to lowest):
- Large Method SynonymsServiceWithDirective.cs: Add
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Positive Code Health Impact (highest to lowest):
- Large Method SynonymsServiceWithDirective.cs: Add
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Improving Code Health:
- Large Method SynonymsServiceWithDirective.cs: Add
ℹ️ Added Directives
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Improving Code Health:
- Large Method SynonymsServiceWithDirective.cs: Add
ℹ️ Added Directives
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Improving Code Health:
- Large Method SynonymsServiceWithDirective.cs: Add
ℹ️ Added Directives
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Improving Code Health:
- Large Method SynonymsServiceWithDirective.cs: Add
ℹ️ Added Directives
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Improving Code Health:
- Large Method SynonymsServiceWithDirective.cs: Add
ℹ️ Added Directives
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Improving Code Health:
- Large Method SynonymsServiceWithDirective.cs: Add
ℹ️ Added Directives
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method SynonymsServiceWithDirective.cs: Add
- Code Duplication SynonymsServiceWithDirective.cs
- Large Method ServiceWithDirective.cs: SomeOtherMethod
✅ Improving Code Health:
- Large Method SynonymsServiceWithDirective.cs: Add
ℹ️ Added Directives
Comment on lines
+235
to
+377
| public bool SomeOtherMethod(string word, List<string> synonyms) | ||
| { | ||
| try | ||
| { | ||
| if (word == "A") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "C") | ||
| { | ||
|
|
||
| } | ||
| //Remove all empty strings, or synonyms that are equal to word, and get Distinct values | ||
| synonyms.RemoveAll(s => string.IsNullOrWhiteSpace(s) || s == word); | ||
| synonyms = synonyms.Distinct().ToList(); | ||
|
|
||
| if (word == null || synonyms.Count == 0) return false; | ||
|
|
||
| //If the word that is a synonym already exists, get the ID. If not, add it | ||
| var synonymsFromCache = _words.Where(x => synonyms.Contains(x.WordString.ToLower())).ToList(); | ||
| var synonymIds = synonymsFromCache.Select(x => x.Id).ToList(); | ||
|
|
||
| //Get synonyms that are not already in cache | ||
| var synonymsNotInCache = synonyms.Where(s => !synonymsFromCache.Select(x => x.WordString).Contains(s)); | ||
|
|
||
| //Add those synonyms | ||
| var (newSynonymIds, nextId) = AddWordsToCache(_words.Count + 1, synonymIds, synonymsNotInCache); | ||
|
|
||
| //Now we have a list of all synonyms, new and old | ||
| var allSynonymIds = synonymIds.Concat(newSynonymIds).ToList(); | ||
|
|
||
| //Check if word already exists | ||
| var existingWord = _words.FirstOrDefault(x => x.WordString == word.ToLower()); | ||
|
|
||
| //If it doesn't, add the word and synonyms | ||
| if (existingWord == null) | ||
| { | ||
| //Add synonyms of synonyms | ||
| synonymsFromCache.ForEach(x => allSynonymIds.AddRange(x.SynonymIds)); | ||
|
|
||
| //Add new word and bind synonyms | ||
| _words.Add(new Word() { Id = nextId, WordString = word.ToLower(), SynonymIds = allSynonymIds.ToList() }); | ||
| allSynonymIds.Add(nextId); | ||
| } | ||
| else | ||
| { | ||
| //If it does, hook only synonyms that aren't already in the list | ||
| HookTheNewSynonymsToWord(existingWord, newSynonymIds); | ||
|
|
||
| //Add the word and its synonyms to all synonyms list | ||
| allSynonymIds.Add(existingWord.Id); | ||
| allSynonymIds.AddRange(existingWord.SynonymIds); | ||
| } | ||
| allSynonymIds = allSynonymIds.ToList(); | ||
|
|
||
| //Update newly added synonyms to have the references to all words | ||
| UpdateAllSynonymsOfSynonyms(allSynonymIds); | ||
|
|
||
| //Update the cache | ||
| _cache.Set(wordListCacheKey, _words); | ||
| return true; | ||
|
|
||
| } | ||
| catch (Exception) | ||
| { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: Add,SomeOtherMethod
| return synonyms; | ||
| } | ||
|
|
||
| // @CodeScene(disable:"Complex Method") |
There was a problem hiding this comment.
❌ New issue: Complex Method
Add has a cyclomatic complexity of 29, threshold = 9
| return synonyms; | ||
| } | ||
|
|
||
| // @CodeScene(disable:"Complex Method") |
There was a problem hiding this comment.
✅ No longer an issue: Large Method
Add is no longer above the threshold for lines of code
Comment on lines
+235
to
+377
| public bool SomeOtherMethod(string word, List<string> synonyms) | ||
| { | ||
| try | ||
| { | ||
| if (word == "A") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "C") | ||
| { | ||
|
|
||
| } | ||
| //Remove all empty strings, or synonyms that are equal to word, and get Distinct values | ||
| synonyms.RemoveAll(s => string.IsNullOrWhiteSpace(s) || s == word); | ||
| synonyms = synonyms.Distinct().ToList(); | ||
|
|
||
| if (word == null || synonyms.Count == 0) return false; | ||
|
|
||
| //If the word that is a synonym already exists, get the ID. If not, add it | ||
| var synonymsFromCache = _words.Where(x => synonyms.Contains(x.WordString.ToLower())).ToList(); | ||
| var synonymIds = synonymsFromCache.Select(x => x.Id).ToList(); | ||
|
|
||
| //Get synonyms that are not already in cache | ||
| var synonymsNotInCache = synonyms.Where(s => !synonymsFromCache.Select(x => x.WordString).Contains(s)); | ||
|
|
||
| //Add those synonyms | ||
| var (newSynonymIds, nextId) = AddWordsToCache(_words.Count + 1, synonymIds, synonymsNotInCache); | ||
|
|
||
| //Now we have a list of all synonyms, new and old | ||
| var allSynonymIds = synonymIds.Concat(newSynonymIds).ToList(); | ||
|
|
||
| //Check if word already exists | ||
| var existingWord = _words.FirstOrDefault(x => x.WordString == word.ToLower()); | ||
|
|
||
| //If it doesn't, add the word and synonyms | ||
| if (existingWord == null) | ||
| { | ||
| //Add synonyms of synonyms | ||
| synonymsFromCache.ForEach(x => allSynonymIds.AddRange(x.SynonymIds)); | ||
|
|
||
| //Add new word and bind synonyms | ||
| _words.Add(new Word() { Id = nextId, WordString = word.ToLower(), SynonymIds = allSynonymIds.ToList() }); | ||
| allSynonymIds.Add(nextId); | ||
| } | ||
| else | ||
| { | ||
| //If it does, hook only synonyms that aren't already in the list | ||
| HookTheNewSynonymsToWord(existingWord, newSynonymIds); | ||
|
|
||
| //Add the word and its synonyms to all synonyms list | ||
| allSynonymIds.Add(existingWord.Id); | ||
| allSynonymIds.AddRange(existingWord.SynonymIds); | ||
| } | ||
| allSynonymIds = allSynonymIds.ToList(); | ||
|
|
||
| //Update newly added synonyms to have the references to all words | ||
| UpdateAllSynonymsOfSynonyms(allSynonymIds); | ||
|
|
||
| //Update the cache | ||
| _cache.Set(wordListCacheKey, _words); | ||
| return true; | ||
|
|
||
| } | ||
| catch (Exception) | ||
| { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
ℹ New issue: Large Method
SomeOtherMethod has 104 lines, threshold = 70
Comment on lines
+235
to
+377
| public bool SomeOtherMethod(string word, List<string> synonyms) | ||
| { | ||
| try | ||
| { | ||
| if (word == "A") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "C") | ||
| { | ||
|
|
||
| } | ||
| //Remove all empty strings, or synonyms that are equal to word, and get Distinct values | ||
| synonyms.RemoveAll(s => string.IsNullOrWhiteSpace(s) || s == word); | ||
| synonyms = synonyms.Distinct().ToList(); | ||
|
|
||
| if (word == null || synonyms.Count == 0) return false; | ||
|
|
||
| //If the word that is a synonym already exists, get the ID. If not, add it | ||
| var synonymsFromCache = _words.Where(x => synonyms.Contains(x.WordString.ToLower())).ToList(); | ||
| var synonymIds = synonymsFromCache.Select(x => x.Id).ToList(); | ||
|
|
||
| //Get synonyms that are not already in cache | ||
| var synonymsNotInCache = synonyms.Where(s => !synonymsFromCache.Select(x => x.WordString).Contains(s)); | ||
|
|
||
| //Add those synonyms | ||
| var (newSynonymIds, nextId) = AddWordsToCache(_words.Count + 1, synonymIds, synonymsNotInCache); | ||
|
|
||
| //Now we have a list of all synonyms, new and old | ||
| var allSynonymIds = synonymIds.Concat(newSynonymIds).ToList(); | ||
|
|
||
| //Check if word already exists | ||
| var existingWord = _words.FirstOrDefault(x => x.WordString == word.ToLower()); | ||
|
|
||
| //If it doesn't, add the word and synonyms | ||
| if (existingWord == null) | ||
| { | ||
| //Add synonyms of synonyms | ||
| synonymsFromCache.ForEach(x => allSynonymIds.AddRange(x.SynonymIds)); | ||
|
|
||
| //Add new word and bind synonyms | ||
| _words.Add(new Word() { Id = nextId, WordString = word.ToLower(), SynonymIds = allSynonymIds.ToList() }); | ||
| allSynonymIds.Add(nextId); | ||
| } | ||
| else | ||
| { | ||
| //If it does, hook only synonyms that aren't already in the list | ||
| HookTheNewSynonymsToWord(existingWord, newSynonymIds); | ||
|
|
||
| //Add the word and its synonyms to all synonyms list | ||
| allSynonymIds.Add(existingWord.Id); | ||
| allSynonymIds.AddRange(existingWord.SynonymIds); | ||
| } | ||
| allSynonymIds = allSynonymIds.ToList(); | ||
|
|
||
| //Update newly added synonyms to have the references to all words | ||
| UpdateAllSynonymsOfSynonyms(allSynonymIds); | ||
|
|
||
| //Update the cache | ||
| _cache.Set(wordListCacheKey, _words); | ||
| return true; | ||
|
|
||
| } | ||
| catch (Exception) | ||
| { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
❌ New issue: Bumpy Road Ahead
SomeOtherMethod has 13 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function
Comment on lines
+161
to
+303
| public bool SomeOtherMethod(string word, List<string> synonyms) | ||
| { | ||
| try | ||
| { | ||
| if (word == "A") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "C") | ||
| { | ||
|
|
||
| } | ||
| //Remove all empty strings, or synonyms that are equal to word, and get Distinct values | ||
| synonyms.RemoveAll(s => string.IsNullOrWhiteSpace(s) || s == word); | ||
| synonyms = synonyms.Distinct().ToList(); | ||
|
|
||
| if (word == null || synonyms.Count == 0) return false; | ||
|
|
||
| //If the word that is a synonym already exists, get the ID. If not, add it | ||
| var synonymsFromCache = _words.Where(x => synonyms.Contains(x.WordString.ToLower())).ToList(); | ||
| var synonymIds = synonymsFromCache.Select(x => x.Id).ToList(); | ||
|
|
||
| //Get synonyms that are not already in cache | ||
| var synonymsNotInCache = synonyms.Where(s => !synonymsFromCache.Select(x => x.WordString).Contains(s)); | ||
|
|
||
| //Add those synonyms | ||
| var (newSynonymIds, nextId) = AddWordsToCache(_words.Count + 1, synonymIds, synonymsNotInCache); | ||
|
|
||
| //Now we have a list of all synonyms, new and old | ||
| var allSynonymIds = synonymIds.Concat(newSynonymIds).ToList(); | ||
|
|
||
| //Check if word already exists | ||
| var existingWord = _words.FirstOrDefault(x => x.WordString == word.ToLower()); | ||
|
|
||
| //If it doesn't, add the word and synonyms | ||
| if (existingWord == null) | ||
| { | ||
| //Add synonyms of synonyms | ||
| synonymsFromCache.ForEach(x => allSynonymIds.AddRange(x.SynonymIds)); | ||
|
|
||
| //Add new word and bind synonyms | ||
| _words.Add(new Word() { Id = nextId, WordString = word.ToLower(), SynonymIds = allSynonymIds.ToList() }); | ||
| allSynonymIds.Add(nextId); | ||
| } | ||
| else | ||
| { | ||
| //If it does, hook only synonyms that aren't already in the list | ||
| HookTheNewSynonymsToWord(existingWord, newSynonymIds); | ||
|
|
||
| //Add the word and its synonyms to all synonyms list | ||
| allSynonymIds.Add(existingWord.Id); | ||
| allSynonymIds.AddRange(existingWord.SynonymIds); | ||
| } | ||
| allSynonymIds = allSynonymIds.ToList(); | ||
|
|
||
| //Update newly added synonyms to have the references to all words | ||
| UpdateAllSynonymsOfSynonyms(allSynonymIds); | ||
|
|
||
| //Update the cache | ||
| _cache.Set(wordListCacheKey, _words); | ||
| return true; | ||
|
|
||
| } | ||
| catch (Exception) | ||
| { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
❌ New issue: Large Method
SomeOtherMethod has 104 lines, threshold = 70
Comment on lines
+161
to
+303
| public bool SomeOtherMethod(string word, List<string> synonyms) | ||
| { | ||
| try | ||
| { | ||
| if (word == "A") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "C") | ||
| { | ||
|
|
||
| } | ||
| //Remove all empty strings, or synonyms that are equal to word, and get Distinct values | ||
| synonyms.RemoveAll(s => string.IsNullOrWhiteSpace(s) || s == word); | ||
| synonyms = synonyms.Distinct().ToList(); | ||
|
|
||
| if (word == null || synonyms.Count == 0) return false; | ||
|
|
||
| //If the word that is a synonym already exists, get the ID. If not, add it | ||
| var synonymsFromCache = _words.Where(x => synonyms.Contains(x.WordString.ToLower())).ToList(); | ||
| var synonymIds = synonymsFromCache.Select(x => x.Id).ToList(); | ||
|
|
||
| //Get synonyms that are not already in cache | ||
| var synonymsNotInCache = synonyms.Where(s => !synonymsFromCache.Select(x => x.WordString).Contains(s)); | ||
|
|
||
| //Add those synonyms | ||
| var (newSynonymIds, nextId) = AddWordsToCache(_words.Count + 1, synonymIds, synonymsNotInCache); | ||
|
|
||
| //Now we have a list of all synonyms, new and old | ||
| var allSynonymIds = synonymIds.Concat(newSynonymIds).ToList(); | ||
|
|
||
| //Check if word already exists | ||
| var existingWord = _words.FirstOrDefault(x => x.WordString == word.ToLower()); | ||
|
|
||
| //If it doesn't, add the word and synonyms | ||
| if (existingWord == null) | ||
| { | ||
| //Add synonyms of synonyms | ||
| synonymsFromCache.ForEach(x => allSynonymIds.AddRange(x.SynonymIds)); | ||
|
|
||
| //Add new word and bind synonyms | ||
| _words.Add(new Word() { Id = nextId, WordString = word.ToLower(), SynonymIds = allSynonymIds.ToList() }); | ||
| allSynonymIds.Add(nextId); | ||
| } | ||
| else | ||
| { | ||
| //If it does, hook only synonyms that aren't already in the list | ||
| HookTheNewSynonymsToWord(existingWord, newSynonymIds); | ||
|
|
||
| //Add the word and its synonyms to all synonyms list | ||
| allSynonymIds.Add(existingWord.Id); | ||
| allSynonymIds.AddRange(existingWord.SynonymIds); | ||
| } | ||
| allSynonymIds = allSynonymIds.ToList(); | ||
|
|
||
| //Update newly added synonyms to have the references to all words | ||
| UpdateAllSynonymsOfSynonyms(allSynonymIds); | ||
|
|
||
| //Update the cache | ||
| _cache.Set(wordListCacheKey, _words); | ||
| return true; | ||
|
|
||
| } | ||
| catch (Exception) | ||
| { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
❌ New issue: Bumpy Road Ahead
SomeOtherMethod has 13 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function
Comment on lines
+306
to
+338
| public bool AddTest(string word) | ||
| { | ||
| try | ||
| { | ||
| if (word == "A") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "A") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| else if (word == "C") | ||
| { | ||
|
|
||
| } | ||
| return true; | ||
| } | ||
| catch (Exception) | ||
| { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
❌ New issue: Bumpy Road Ahead
AddTest has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function
Comment on lines
+161
to
+303
| public bool SomeOtherMethod(string word, List<string> synonyms) | ||
| { | ||
| try | ||
| { | ||
| if (word == "A") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "BB") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| else if (word == "C") | ||
| { | ||
|
|
||
| } | ||
| //Remove all empty strings, or synonyms that are equal to word, and get Distinct values | ||
| synonyms.RemoveAll(s => string.IsNullOrWhiteSpace(s) || s == word); | ||
| synonyms = synonyms.Distinct().ToList(); | ||
|
|
||
| if (word == null || synonyms.Count == 0) return false; | ||
|
|
||
| //If the word that is a synonym already exists, get the ID. If not, add it | ||
| var synonymsFromCache = _words.Where(x => synonyms.Contains(x.WordString.ToLower())).ToList(); | ||
| var synonymIds = synonymsFromCache.Select(x => x.Id).ToList(); | ||
|
|
||
| //Get synonyms that are not already in cache | ||
| var synonymsNotInCache = synonyms.Where(s => !synonymsFromCache.Select(x => x.WordString).Contains(s)); | ||
|
|
||
| //Add those synonyms | ||
| var (newSynonymIds, nextId) = AddWordsToCache(_words.Count + 1, synonymIds, synonymsNotInCache); | ||
|
|
||
| //Now we have a list of all synonyms, new and old | ||
| var allSynonymIds = synonymIds.Concat(newSynonymIds).ToList(); | ||
|
|
||
| //Check if word already exists | ||
| var existingWord = _words.FirstOrDefault(x => x.WordString == word.ToLower()); | ||
|
|
||
| //If it doesn't, add the word and synonyms | ||
| if (existingWord == null) | ||
| { | ||
| //Add synonyms of synonyms | ||
| synonymsFromCache.ForEach(x => allSynonymIds.AddRange(x.SynonymIds)); | ||
|
|
||
| //Add new word and bind synonyms | ||
| _words.Add(new Word() { Id = nextId, WordString = word.ToLower(), SynonymIds = allSynonymIds.ToList() }); | ||
| allSynonymIds.Add(nextId); | ||
| } | ||
| else | ||
| { | ||
| //If it does, hook only synonyms that aren't already in the list | ||
| HookTheNewSynonymsToWord(existingWord, newSynonymIds); | ||
|
|
||
| //Add the word and its synonyms to all synonyms list | ||
| allSynonymIds.Add(existingWord.Id); | ||
| allSynonymIds.AddRange(existingWord.SynonymIds); | ||
| } | ||
| allSynonymIds = allSynonymIds.ToList(); | ||
|
|
||
| //Update newly added synonyms to have the references to all words | ||
| UpdateAllSynonymsOfSynonyms(allSynonymIds); | ||
|
|
||
| //Update the cache | ||
| _cache.Set(wordListCacheKey, _words); | ||
| return true; | ||
|
|
||
| } | ||
| catch (Exception) | ||
| { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
❌ New issue: Deep, Nested Complexity
SomeOtherMethod has a nested complexity depth of 20, threshold = 4
Comment on lines
+306
to
+338
| public bool AddTest(string word) | ||
| { | ||
| try | ||
| { | ||
| if (word == "A") | ||
| { | ||
|
|
||
| } | ||
| else if (word.Contains("B")) | ||
| { | ||
| if (word == "BA") | ||
| { | ||
|
|
||
| } | ||
| else if (word == "BB") | ||
| { | ||
| if (word == "A") | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| else if (word == "C") | ||
| { | ||
|
|
||
| } | ||
| return true; | ||
| } | ||
| catch (Exception) | ||
| { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
❌ New issue: Deep, Nested Complexity
AddTest has a nested complexity depth of 5, threshold = 4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.