Fix install path of icons on Linux #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
WOnder93
force-pushed
the
fix-icons-destination
branch
2 times, most recently
from
6136b67 to
17f880c
Compare
The current hack with explicit "install" invocation is broken because it doesn't respect the $(INSTALL_ROOT) variable. Avoid manual installation of the icons by naming all of them "chessx.png" and placing them into individual subdirectories according to the size. Unfortunately the native Qt install targets do not provide a way to rename the files when installing, so this is the only way to avoid running unix commands by hand. Additionally also fix the destination path of the main icon, which is now 256 pixels instead of 128. Signed-off-by: Ondrej Mosnáček <omosnacek@gmail.com>
WOnder93
force-pushed
the
fix-icons-destination
branch
from
17f880c to
8313b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current hack with explicit "install" invocation is broken because it
doesn't respect the $(INSTALL_ROOT) variable. Avoid manual installation
of the icons by naming all of them "chessx.png" and placing them into
individual subdirectories according to the size.
Unfortunately the native Qt install targets do not provide a way to
rename the files when installing, so this is the only way to avoid
running unix commands by hand.