set FlatFab version from cmake; remove qmake support #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainwindow.cpp gets FlatFab version from CMake directly (to avoid setting it twice) Doing so prevents compiling the code via qmake, so remove qmake support.
skadge
force-pushed
the
cmake_version
branch
from
69e854e to
3930ac9
Compare
Owner
|
Updated README.md with cmake-specific instructions in 6f74b5f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainwindow.cpp gets FlatFab version from CMake directly (to avoid setting it twice)
Doing so prevents compiling the code via qmake, so remove qmake support.
Note that CMake is fully supported by (recent enough) QtCreator (and qmake is deprecated with Qt6 anyway). Project confirmed to compile and run with QtCreator 14 for instance.