Delimiters in search results to break up results into sub-sections #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Current code results:
Thoughts:
Delimiters could be toggled.
Delimiters are derived from the selected sort.
Would it be useful to have a delimiter for all weapons that sorts by damage type and then damage value?
Or maybe All category with delimiters for each other category?
Probably not that useful, user would likely just click on category or subcategory if they wanted to look at something specific.
Toggle somewhere?
Dynamic delimiter value bounds?
Empty sections should not have the header shown or the previous header should include it.