-
Notifications
You must be signed in to change notification settings - Fork 2
Make book target resilient to all component failures #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove test as a hard dependency from book target - Add conditional test execution within book target - Tests will run if available but won't block book generation - Fixes issue where book fails if tests don't exist or fail Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
- Remove duplicate test folder check - Rely on test target's built-in handling of missing tests - Cleaner and more maintainable code - Addresses code review feedback Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
|
@copilot Do the same trick for docs and marimushka |
- Remove docs and marimushka as hard dependencies from book target - Add conditional execution for docs and marimushka with error handling - Book will continue if docs or marimushka fail or are unavailable - Addresses feedback to apply same trick for docs and marimushka Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
- Use consistent phrasing across all three targets - All warnings now say "failed or unavailable" - Improves code consistency and readability Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
|
I worry about silent failures here like we saw in loman |
|
I think for the book this makes sense. it creates all those content-cards only if the related job was successful. So, people may have no tests but the book is still working. If you then expect pages in the book that are missing you can see in the warnings for 'make book' that 'make test' did not work. The alternative is that we keep having an empty standard 'make test' somewhere not in the tests folder? |
make bookfails when any of its component targets (tests, docs, or marimushka) are unavailable or fail, blocking documentation generation. Reported in projects without test infrastructure or with failing test suites, docs generation issues, or missing notebooks.Changes
booktarget no longer depends ontest,docs, ormarimushkatargets$(MAKE) <target> || printf warningBook generation now succeeds in all scenarios: all components passing, any combination failing, or any/all components absent.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.