Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026

Security scanning targets (pip-audit, bandit) were buried in tests/tests.mk. Extracted to security/security.mk for better discoverability and consistency with other feature modules (docker/, book/, presentation/).

Changes

  • Created security/security.mk with security target
  • Removed security target from tests/tests.mk
  • Updated .rhiza/rhiza.mk to include security/security.mk

The security target behavior is unchanged:

security: install ## run security scans (pip-audit and bandit)
	@${UVX_BIN} pip-audit
	@${UVX_BIN} bandit -r ${SOURCE_FOLDER} -ll -q

Now surfaces in make help under dedicated ##@ Security section.

Original prompt

This section details on the original issue you should resolve

<issue_title>Make security an own folder with security.mk</issue_title>
<issue_description>currently security jobs are hidden test.mk</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
Copilot AI changed the title [WIP] Create security folder with security.mk file Refactor security target into dedicated security/ folder Jan 27, 2026
Copilot AI requested a review from tschm January 27, 2026 18:35
@tschm tschm marked this pull request as ready for review January 27, 2026 19:33
@tschm tschm requested a review from HarryCampion January 27, 2026 19:49
@HarryCampion
Copy link
Collaborator

This might be overkill to have its' own folder? unless you envisage artefacts like we see in presentation, book, docker etc?

@tschm
Copy link
Member

tschm commented Jan 28, 2026

would it be better to have security.mk in make.d? Or no security.mk at all? Currently it's hidden in test.mk. Some users won't use tests, e.g. no tests folder, no test.mk and hence rhiza_security will fail as 'make security' will fail

@tschm tschm closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make security an own folder with security.mk

3 participants