Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

The typecheck and docs-coverage targets in src.mk used unquoted src arguments while other targets (mypy, docs, security) consistently quoted them.

Changes:

  • typecheck target: mypy srcmypy "src"
  • docs-coverage target: interrogate -vv srcinterrogate -vv "src"

All command-line references to the source directory are now consistently quoted throughout the file.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 28, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] WIP Address feedback on PR 434 for src.mk implementation Standardize "src" quoting in src.mk Makefile targets Jan 28, 2026
Copilot AI requested a review from tschm January 28, 2026 11:00
Signed-off-by: Thomas Schmelzer <thomas.schmelzer@gmail.com>
@tschm tschm marked this pull request as ready for review January 28, 2026 11:02
@tschm tschm merged commit 396242a into 434-srcmk-for-src Jan 28, 2026
@tschm tschm deleted the copilot/sub-pr-436 branch January 28, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants