Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Addresses feedback from PR #436 review to remove commented-out code in test_mypy_target_dry_run.

Changes

  • Removed commented-out directory setup and environment configuration code (8 lines)
  • Code became redundant when src/src.mk was added to SPLIT_MAKEFILES - the fixture now creates the src/ directory automatically when copying split makefiles

Context

The test fixture setup_tmp_makefile creates parent directories for all split makefiles, making the manual src/ directory creation and SOURCE_FOLDER environment variable setup unnecessary.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
@tschm tschm marked this pull request as ready for review January 28, 2026 11:03
Copy link
Contributor Author

Copilot AI commented Jan 28, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] WIP address changes based on feedback from PR #436 review Remove commented-out test code that is no longer needed Jan 28, 2026
Copilot AI requested a review from tschm January 28, 2026 11:04
@tschm tschm merged commit 5b22855 into 434-srcmk-for-src Jan 28, 2026
@tschm tschm deleted the copilot/sub-pr-436-again branch January 28, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants