Attempt to fix <root/> entries that specify a database#98
Open
jermdavis wants to merge 2 commits intoJeffDarchuk:masterfrom
Open
Attempt to fix <root/> entries that specify a database#98jermdavis wants to merge 2 commits intoJeffDarchuk:masterfrom
jermdavis wants to merge 2 commits intoJeffDarchuk:masterfrom
Conversation
…'s database is "core" rather than "master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first pass at a fix for the issue raised in #97, addressing the ContentMigrator module and a few core bits.
I've tried to rework a collection of API calls and method signatures so that databases are passed about correctly. Which should allow syncing the core database to work. There are probably better (neater) fixes to some of these issues, but the changes in this PR has been done quickly to enable a colleague to get on with some work, rather than be the ideal fix.
It's not exhaustively tested. I've done testing against a "localhost" root - which will successfully expand a core db tree, and preview/sync. (Obvs with no actual changes...) And my colleague who raised the original issue with me has also tested it between separate instances of his solution, and says that appears to be working similarly.
I wasn't able to make the unit tests run correctly in the v1.7 codebase (I get ~50 failed tests with the unchanged code) so I've not put effort into ensuring the tests aren't affected by these changes. The tests compile - but I didn't have time to work out if these failures were because the tests are broken, or because I was doing this in Sitecore v10 and VS2022.
Shout if you need any other work/changes to get this merged.