Some tiny performance improvements #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M mri/mri_sensemap_denoise.m Forcing parfor to avoid queueing sMaps estimation M penalty/Cdiff.m ndims()'s return always >= 2 M systems/@fatrix2/cat.m Avoid nesting @fatrix2 when numel(varargin)==1 M systems/@fatrix2/mtimes.m Enabling A*c, where A is a @fatrix2, c is a scalar M systems/@fatrix2/private/fatrix2_subsref_colon.m Use parfor for fatrix2-matrix product, when parpool is already init'ed, (init parpool can be expensive by itself, hence parfor only when parpool is already available) M systems/Gmri.m Enabling default nufft_args to support 3D; Substituting repmat w/ bsxfun, RAM friendly.
|
Seems like this adds the dependency for parallel toolbox which MIRT doesn't assume? |
Author
Right, but I think it is safe to assume user who needs sMap estimation has access to the parallel toolbox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing parfor to avoid queueing sMaps estimation, which could be slow in, e.g., 32-channel case.
Matlab ndims()'s return always >= 2.
Avoid nesting @fatrix2 when numel(varargin)==1
Enabling A*c, where A is a @fatrix2, c is a scalar.
Use parfor for fatrix2-matrix product, when parpool is already init'ed, (initialize a parpool can be expensive by itself, hence only use parfor when parpool is already available)
Enabling default nufft_args to support 3D;
Substituting repmat w/ bsxfun, RAM friendly.