fix: unify the loggers #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-dilks
added a commit
that referenced
this pull request
Nov 17, 2025
This PR extends #951 by replacing all `Logger.getLogger` patterns with `SplitLogger.create`.
c-dilks
requested review from
N-Plx,
baltzell,
drewkenjo,
efuchey,
forcar,
ftouchte,
hauenst,
mathieuouillon,
mpaolone,
raffaelladevita,
tongtongcao,
whit2333 and
zieglerv
as code owners
baltzell
approved these changes
Nov 22, 2025
baltzell
approved these changes
Nov 22, 2025
c-dilks
added a commit
that referenced
this pull request
Nov 24, 2025
This PR extends #951 by replacing all `Logger.getLogger` patterns with `SplitLogger.create`.
tongtongcao
pushed a commit
that referenced
this pull request
Dec 5, 2025
* refactor!: remove `DefaultLogger` * feat: propagate log level of `OptionParser` to its owner's class instances * refactor: rename and document * fix: sync levels for all classes in `postprocess` * fix: just apply the level to all new `SplitLogger`s * fix: syncing * fix: depana * doc: singleton
tongtongcao
pushed a commit
that referenced
this pull request
Dec 5, 2025
* refactor!: remove `DefaultLogger` * feat: propagate log level of `OptionParser` to its owner's class instances * refactor: rename and document * fix: sync levels for all classes in `postprocess` * fix: just apply the level to all new `SplitLogger`s * fix: syncing * fix: depana * doc: singleton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OptionParserdefault log level fromFINEtoINFO; this means logs will be quieter by defaultDefaultLogger.debug(), which effectively sets the log level toFINE, will also be quieter🐛 Bug Fix 🐛
DefaultLogger, fixing Stderr and stdout are being hijacked #947, since usingDefaultLoggerandSplitLoggersimultaneously causes neither of them to work at allLogger.getLoggerand similar) remain for nowSplitLoggerfor all loggers #952 is a followup PR that proposes converting them toSplitLoggerSplitLoggereverywhere "should" fix things once and for all🚧 Features 🚧
OptionParser(which user sets with-l) to all newSplitLoggerinstancesSplitLoggerConfigparser.syncLogLevel()may be used to set the level of aLoggerto match this level; typically used when anOptionParserinstance owner also owns aLoggerinstanceparser.overrideLogLevel()may be used to override the level of aSplitLoggerfor any class, to handle the case where we don't want the level ofOptionParserorSplitLoggerConfigto be used