Skip to content

Conversation

@kelseymorsebrown
Copy link
Collaborator

@kelseymorsebrown kelseymorsebrown commented Aug 8, 2024

#44 Trying to take a stab at upgrading dependencies to resolve a whole bunch of vulnerabilities we keep getting alerts about in upstream systems using lateralus.

Here is a list of package upgrades and the vulnerabilities they resolve

Dependencies

Dev Dependencies

@kelseymorsebrown
Copy link
Collaborator Author

I feel like I must be missing something with the webpack upgrade - npm run start is successful but when I try to load http://127.0.0.1:8080/test/ per the README, there's a GET error. 🤔

@jeremyckahn
Copy link
Contributor

I feel like I must be missing something with the webpack upgrade - npm run start is successful but when I try to load http://127.0.0.1:8080/test/ per the README, there's a GET error. 🤔

It looks like the docs are out of date (or incorrect, at least). Sorry about that. 😅

Based on the contents of webpack.test.config.cjs, I wouldn't expect anything to be available at http://127.0.0.1:8080/test/ when running npm run start:

"start": "webpack serve --open --config webpack.test.config.cjs",

const config = require('./webpack.common');
const { merge } = require('webpack-merge');
const path = require('path');
module.exports = merge(config, {
entry: './test/index.js',
output: {
path: path.join(__dirname, 'dist'),
publicPath: '/assets/',
filename: 'index.js',
library: 'index',
libraryTarget: 'umd',
umdNamedDefine: true
},
mode: 'development',
devServer: {
static: './dist',
}
});

However, I do see lateralus.js and lateralus.js.map being served from http://localhost:8080/:

Screenshot of localhost

@jeremyckahn
Copy link
Contributor

It appears that the README is accurate for the develop branch:

Screenshot of tests

So, it seems that something in this PR has caused things to work unexpectedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants