proof of concept dynamic pitch angle#11
Draft
halvorgb wants to merge 6 commits intoJelvan1:masterfrom
Draft
Conversation
seperated color variables into max, submax and badmax. badmax means that this quadrant/face is just a bad combination and plasma climbs are affected. submax is almost as good as the optimal angle. max is the optimal angle, and different to badmax it is the best we can do in quake. Still some gaps between the submax and max pitch angles.
Author
|
Unsure why this fails on macOS 64-bit, the error doesn't give any useful information. Some sort of timeout after 50 minutes? |
Owner
|
Thanks for the proof of concept, will have a look at it later. About the build error, I've seen the same thing happen on Linux and Windows a few months ago, but I could never replicate this on my system. Now it's macOS for some reason (see #10 ). You can ignore this for the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables a dynamic optimal pitch angle for plasma climbing, with some new cvars. This picture has been the reference for these angles:
The code and cvars refer to three max-angles:
max,submaxandbadmax.In the reference picture we can see that the max climb height varies within the range.
submaxdefaults to orange and is almost as good as max.maxdefaults to green.badmaxdefaults to red. From the picture it is the 73.4-74.0 -> 1112u one. It is the best angle in those circumstances, but should be avoided if possible (by choosing another wall to climb on).Video demonstration:
https://streamable.com/fr6eaw
I don't know if the reference picture is correct, I have no reason to doubt it though.
Also, I'm not a C programmer really so you'll probably want to rewrite this if you want it in your project. 😃